Mixed new line markers causing OOPS while submitting translations
Bug #742662 reported by
Diogo Matsubara
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Benji York |
Bug Description
10 MixedNewlineMar
POST: 10 Robots: 0 Local: 10
9 https:/
OOPS-1909EA1131, OOPS-1909EB1011, OOPS-1909EB1023, OOPS-1909EC1037, OOPS-1909EC1038, OOPS-1909ED1083, OOPS-1909ED1084, OOPS-1909EE1073, OOPS-1909EE1077
1 https:/
OOPS-1909H2071
Related branches
lp:~benji/launchpad/bug-742662
Rejected
for merging
into
lp:launchpad
- Graham Binns (community): Approve (code)
-
Diff: 313 lines (+146/-14)5 files modifiedlib/lp/translations/utilities/sanitize.py (+23/-7)
lib/lp/translations/utilities/tests/test_file_importer.py (+22/-4)
lib/lp/translations/utilities/tests/test_sanitize.py (+21/-0)
lib/lp/translations/utilities/tests/test_translation_importer.py (+63/-1)
lib/lp/translations/utilities/translation_import.py (+17/-2)
lp:~benji/launchpad/bug-742662-2
- Steve Kowalik (community): Approve (code)
-
Diff: 180 lines (+54/-30)3 files modifiedlib/lp/translations/utilities/sanitize.py (+49/-23)
lib/lp/translations/utilities/tests/test_file_importer.py (+3/-4)
lib/lp/translations/utilities/tests/test_sanitize.py (+2/-3)
summary: |
- Mixed new line markers causing OOPS + Mixed new line markers causing OOPS while importing translations |
tags: | added: rosetta-imports |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Benji York (benji) |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
So we should do one of:
- reject this during import
- handle it [preserve the newline styles in the translation]
- show a clear error on the page