product:+code-index merge proposal queries do not show private bugs visible by assignment

[Robert Collins]

Bug visibility rules were changed recently to permit assignees to see private bugs, but (at least) one code path was missed - the Product:+code-index duplicates the visibility rules and was not updated.

[Robert Collins (lifeless)]

I think this may be in scope for disclosure; if not please untag it.

[j.c.sackett (jcsackett)]

Curtis and I did a fair amount of investigation today, and the cause is actually less obvious.

We replicated this problem by assigning me to a bug on qastaging.launchpad.net/gdp, which Curtis had linked to a branch. On code.qastaging.launchpad.net/gdp we confirmed that I could see the branch in the listing, but could not see the badge for the bug.

Our initial guess after investigation was the BranchBadges .isBugBadgeVisible method was reporting bad data, probably because of something in linked_bugs on the branch or in the _known_viewers cache. A test, which you can see in lp:~jcsackett/launchpad/branch-listings-private-bugs that should have failed, revealing this problem, passes.

After more investigation, we're no longer certain what the root cause is. We will continue investigating.

[Ian Booth (wallyworld)]

I have found the issue. The BugBranchSet method getBranchesWithVisibleBugs() is flawed.
If returns branches with bugs where the user is subscribed to the bug, but does not check that the user is assigned to the bug. Adding this check makes everything work. The codebase sadly appears to contain similar snippets (but constructed differently to suit the parent query) to check for bug/branch visibility.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r14772 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14772>.