Code review comment via email truncated, most content lost!

[Andrew Bennetts]

I just replied to a code review email via email, and discovered some time later that my reply was truncated to just the first three lines! The merge proposal is <https://code.launchpad.net/~mgiuca/bzr/log-not-in-branch/+merge/53955>.

I'll attach the email as sent by my MUA, including headers. I'm going to boldly go ahead and mark this critical, it seems like a potential dataloss issue (I only recovered my data because I keep a copy of my sent mail *and* I happened to notice later that my reply was truncated. There's a bit more luck involved there than I'd like.)

(For bonus points, I had to enter this bug twice because I accidentally bumped the "back" button on my keyboard, and because of ajax stuff going forward to return to +filebug loses the bug details I had filled in.)

[Robert Collins (lifeless)]

I'm tentatively tagging this as a regression - we've altered mail handling recently as part of fixing some incoming oopses

[Matt Giuca (mgiuca)]

Might I *guess* (without having any experience with the code) that it was caused by the double-quoting in the email? The email is formatted like this:

X wrote:
> > Two-levels deep quote
> > etc
>
> One-level deep quote
> etc

My opinion

And the resulting comment was:

X wrote:
> > Two-levels deep quote
> > etc

There is probably some code in Launchpad which detects one-level-deep quoting and cuts it out (because you don't want people who top-post to have the entire previous message included in the thread). For some reason, the fact that you have a double-quote followed by a single-quote must have confused it into thinking you were top-posting, and cut out everything below and including the one-level-deep quotes.

[Andrew Bennetts (spiv)]

Matt: it's possible, but from what I know it seems unlikely to me. I've sent many emails to bugs and code reviews in that style over the past few years with no trouble. And the last time I paid attention to the LP code for this the filtering of quoted text is done when formatting the web page, not during processing of the incoming email: after all, when LP relays the email to other subscribers it wants to keep the original quoting intact.

[William Grant (wgrant)]

That email is processed fine locally. MTA mangling of some variety?

[Martin Pool (mbp)]

did you sign this message, or did you send it just exactly as in the attachment?

[Andrew Bennetts (spiv)]

Martin Pool wrote:
> did you sign this message, or did you send it just exactly as in the
> attachment?

Not signed, exactly as in the attachment.

[John A Meinel (jameinel)]

Andrew had sent the email both to Launchpad and direct to myself. It came through correct to myself, but the copy that LP forwards on (for Review: approve purposes?) was broken and had no content, only the quoted section.

I can attach stuff if you like, though I'm guessing it will look a whole lot like what Andrew attached.