Feature flags not enabled in Soyuz scripts
Bug #735319 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
During Q/A for bug 730460 we found that the scripts that need to generate DistroSeriesDif
We'll have to set up the feature flag controller similarly to what's done in features/webapp.py.
Scripts affected: process-upload.py, gina.py, copy-package.py, possibly more.
We can use the script id as the "page id." We may also need to hack things up a bit to avoid the controller talking to the WSGI stack.
Related branches
lp:~jtv/launchpad/bug-735319
- Martin Pool (community): Approve (code*)
-
Diff: 728 lines (+297/-82)14 files modifiedlib/canonical/launchpad/doc/librarian.txt (+26/-23)
lib/canonical/launchpad/doc/timeout.txt (+8/-7)
lib/canonical/launchpad/webapp/publication.py (+1/-1)
lib/lp/bugs/browser/tests/test_bugattachment_file_access.py (+6/-6)
lib/lp/registry/browser/tests/test_series_views.py (+4/-7)
lib/lp/services/features/__init__.py (+21/-2)
lib/lp/services/features/scopes.py (+65/-17)
lib/lp/services/features/testing.py (+8/-5)
lib/lp/services/features/tests/test_flags.py (+5/-4)
lib/lp/services/features/tests/test_scopes.py (+67/-0)
lib/lp/services/features/webapp.py (+6/-4)
lib/lp/services/scripts/base.py (+12/-0)
lib/lp/services/scripts/tests/test_feature_controller.py (+61/-0)
lib/lp/testing/__init__.py (+7/-6)
description: | updated |
description: | updated |
description: | updated |
description: | updated |
tags: | added: feature-flags |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12632 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12632>.