IBranch.canBeDeleted docstring wrong about subscriptions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Chris Johnston |
Bug Description
IBranch says:
def canBeDeleted():
"""Can this branch be deleted in its current state.
A branch is considered deletable if it has no revisions, is not
linked to any bugs, specs, productseries, or code imports, and
has no subscribers.
"""
But TestBranchDeletion says:
def test_subscripti
"""A branch that has a subscription can be deleted."""
Only one of those two can be right. I assume the test is correct, so I guess the fix is to remove the “has no subscribers” claim from the canBeDeleted docstring.
Related branches
- William Grant (community): Approve (code)
- Chris Johnston (community): Needs Resubmitting
- Celso Providelo (community): Approve
-
Diff: 15 lines (+2/-3)1 file modifiedlib/lp/code/interfaces/branch.py (+2/-3)
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: docs trivial |
Changed in launchpad: | |
status: | Triaged → Fix Committed |
assignee: | nobody → Chris Johnston (cjohnston) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r16983 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 16983>.