IBranch.canBeDeleted docstring wrong about subscriptions

Bug #726465 reported by Andrew Bennetts on 2011-02-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Chris Johnston

Bug Description

IBranch says:

    def canBeDeleted():
        """Can this branch be deleted in its current state.

        A branch is considered deletable if it has no revisions, is not
        linked to any bugs, specs, productseries, or code imports, and
        has no subscribers.
        """

But TestBranchDeletion says:

    def test_subscriptionDoesntDisableDeletion(self):
        """A branch that has a subscription can be deleted."""
        self.branch.subscribe(
            self.user, BranchSubscriptionNotificationLevel.NOEMAIL, None,
            CodeReviewNotificationLevel.NOEMAIL, self.user)
        self.assertEqual(True, self.branch.canBeDeleted())

Only one of those two can be right. I assume the test is correct, so I guess the fix is to remove the “has no subscribers” claim from the canBeDeleted docstring.

Related branches

Curtis Hovey (sinzui) on 2011-02-28
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
tags: added: docs trivial
Changed in launchpad:
status: Triaged → Fix Committed
assignee: nobody → Chris Johnston (cjohnston)
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
William Grant (wgrant) on 2014-04-15
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2014-04-16
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers