BugTask:+index timeout - late evaluation of Person/ValidPersonCache

[Robert Collins]

    5 https://bugs.launchpad.net/ubuntu/+bug/1/+index (BugTask:+index)
       OOPS-1884G2180, OOPS-1884H2231, OOPS-1884O2001, OOPS-1884O2002, OOPS-1884O2110
      4 https://bugs.launchpad.net/ubuntu/+bug/1/+index (BugTask:+index)
       OOPS-1884C856, OOPS-1884D1882, OOPS-1884F1987, OOPS-1884F879

consistently high python time.

The new appservers may help.

Am getting memcache turned off as its showing up with very large request counts and slow (24ms) individual gets that miss.

[Robert Collins (lifeless)]

turning memcache off has helped, as have other optimisations. Still need to track the late evaluation down.

[Robert Collins (lifeless)]

  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/zope.tales-3.4.0-py2.6.egg/zope/tales/expressions.py", line 211, in _eval
    return ob()
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/browser/bugtask.py", line 3269, in getBugTaskAndNominationViews
    conjoined_master is not None)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/browser/bugtask.py", line 3207, in _getTableRowView
    view.target_link_title = self.getTargetLinkTitle(context.target)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/browser/bugtask.py", line 3181, in getTargetLinkTitle
    uploader = current_release.creator
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/lazr.delegates-1.2.0-py2.6.egg/lazr/delegates/_delegates.py", line 130, in __get__
    return getattr(context, self.name)

[Robert Collins (lifeless)]

from getTargetLinkTitle:
uploader = current_release.creator
maintainer = current_release.maintainer

[Robert Collins (lifeless)]

Remaining case -

  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/zope.traversing-3.8.0-py2.6.egg/zope/traversing/adapters.py", line 138, in traversePathElement
    return traversable.traverse(nm, further_path)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/app/browser/tales.py", line 607, in traverse
    return getattr(self, method_name)(extra_path)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/app/browser/tales.py", line 1189, in link
    return self._makeLink(view_name, rootsite, self._context.displayname)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/app/browser/tales.py", line 1174, in _makeLink
    css_class = ObjectImageDisplayAPI(person).sprite_css()
  File "/srv/launchpad.net/codelines/trunk/lib/lp/app/browser/tales.py", line 722, in sprite_css
    if context.is_valid_person:
  File "/srv/launchpad.net/codelines/trunk/lib/lp/services/propertycache.py", line 116, in __get__
    value = self.populate(instance)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/registry/model/person.py", line 1243, in is_valid_person
    ValidPersonCache.get(self.id)

not sure what person its rendering to trigger this yet.

[Robert Collins (lifeless)]

  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/browser/bug.py", line 275, in nominate
    if check_permission("launchpad.Driver", target):
  File "/srv/launchpad.net/codelines/trunk/lib/canonical/launchpad/webapp/authorization.py", line 251, in check_permission
    return zcheckPermission(permission_name, context)
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/zope.security-3.7.1-py2.6-linux-i686.egg/zope/security/management.py", line 143, in checkPermission

is another cause

[Robert Collins (lifeless)]

the cases in comment #3 are fixed.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12521 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12521>.

[Robert Collins (lifeless)]

Note that this bug won't be fully fixed by this landing - there are multiple root causes we need to address one by one.