OOPS created when a canonical.com site links to a private page w/out access

Bug #719637 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Benji York

Bug Description

We generate an OOPS when a 404 occurs *and* the referrer is launchpad itself, or a number of select related sites (like canonical.com). OOPS-1872D1945 was triggered when a staff member followed a link on the wiki to a team which is private and they couldn't see.

This behaviour is correct if launchpad had generated the link - we shouldn't generate links to confidential things someone cannot access. However related sites with static links may put the URL for confidential things so that staff know how to get at the thing *once* they are granted access.

One way to stop this OOPS occuring would be to only care about 404s on referrers from LP (and (dev,help).launchpad.net itself), not related sites. That wouldn't help us fix bad links on those sites - but on the other hand users of those sites are going to seek assistance immediately rather than waiting for intervention.

Another, more complex approach would be to categorise 404s into 'hidden' and 'really not there' and then for hidden cases from not-launchpad-itself squelch the OOPS.

Of these two solutions I suspect the simplest solution is best - but there may be other approaches.

Tags: oops qa-ok

Related branches

Revision history for this message
Curtis Hovey (sinzui) wrote :

This issue may become moot when implement the disclosure feature. The intent to to permit grant view on teams and projects. The specific case for knowing we are done is when canonical staff can see private canonical teams, bugs, and branches. I believe the 404+oops could only happen for users who are not authenticated.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 719637] Re: OOPS created when a canonical.com site links to a private page w/out access

Indeed, but even then we wouldn't want an OOPS in this particular case.

Benji York (benji)
Changed in launchpad:
assignee: nobody → Benji York (benji)
Benji York (benji)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Benji York (benji) wrote :

This was mostly fixed along with bug 730393. However, a new incarnation of the bug was introduced at that time that caused NotFound (and similar errors) to OOPS if no referer is set. This happens in production (e.g., OOPS-1970CF506). The linked branch fixes this.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Benji York (benji)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.