unassigning a private bug results in a red error box

[Robert Collins]

I had a bug 447550 which is private, that I can only see because I'm the assignee. I unassigned myself and this generated a big red backtrace box as a result:

Presumably this is because once unassigned, I can't see the bug anymore. So the unassignment access drop has to be deferred to end of transaction. I suggest by caching the access permission on the bug.

Unauthorized
(, 'getBugNotificationRecipients', 'launchpad.View')

Traceback (most recent call last):
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.publisher-3.12.0-py2.6.egg/zope/publisher/publish.py", line 134, in publish
    result = publication.callObject(request, obj)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/lazr.restful-0.16.0-py2.6.egg/lazr/restful/publisher.py", line 173, in callObject
    WebServicePublicationMixin, self).callObject(request, object)
  File "/srv/launchpad.net/production/launchpad-rev-12351/lib/canonical/launchpad/webapp/publication.py", line 486, in callObject
    return mapply(ob, request.getPositionalArguments(), request)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.publisher-3.12.0-py2.6.egg/zope/publisher/publish.py", line 109, in mapply
    return debug_call(obj, args)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.publisher-3.12.0-py2.6.egg/zope/publisher/publish.py", line 115, in debug_call
    return obj(*args)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/lazr.restful-0.16.0-py2.6.egg/lazr/restful/_resource.py", line 926, in __call__
    result = self.do_PATCH(media_type, representation)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/lazr.restful-0.16.0-py2.6.egg/lazr/restful/_resource.py", line 1551, in do_PATCH
    return self.applyChanges(changeset)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/lazr.restful-0.16.0-py2.6.egg/lazr/restful/_resource.py", line 1197, in applyChanges
    notify(event)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.event-3.4.1-py2.6.egg/zope/event/__init__.py", line 23, in notify
    subscriber(event)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/event.py", line 26, in dispatch
    zope.component.subscribers(event, None)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/_api.py", line 138, in subscribers
    return sitemanager.subscribers(objects, interface)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/registry.py", line 323, in subscribers
    return self.adapters.subscribers(objects, provided)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.interface-3.5.2-py2.6-linux-x86_64.egg/zope/interface/adapter.py", line 579, in subscribers
    subscription(*objects)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/event.py", line 34, in objectEventNotify
    zope.component.subscribers((event.object, event), None)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/_api.py", line 138, in subscribers
    return sitemanager.subscribers(objects, interface)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.component-3.9.3-py2.6.egg/zope/component/registry.py", line 323, in subscribers
    return self.adapters.subscribers(objects, provided)
  File "/srv/launchpad.net/production/launchpad-rev-12351/eggs/zope.interface-3.5.2-py2.6-linux-x86_64.egg/zope/interface/adapter.py", line 579, in subscribers
    subscription(*objects)
  File "/srv/launchpad.net/production/launchpad-rev-12351/lib/canonical/database/sqlbase.py", line 754, in block_implicit_flushes_decorator
    return func(*args, **kwargs)
  File "/srv/launchpad.net/production/launchpad-rev-12351/lib/lp/bugs/subscribers/bugtask.py", line 73, in notify_bugtask_edited
    new_subscribers=new_subs)
  File "/srv/launchpad.net/production/launchpad-rev-12351/lib/lp/bugs/subscribers/bug.py", line 203, in add_bug_change_notifications
    recipients = bug_delta.bug.getBugNotificationRecipients(
Unauthorized: (, 'getBugNotificationRecipients', 'launchpad.View')

[Robert Collins (lifeless)]

Oh, and of course, the exception means that the request oops and the unassignment is aborted.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12650 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12650>.

[Robert Collins (lifeless)]

On reflection I suspect this wasn't a regression.