prf WalkerBase.walk can fail if self.open raises an exception
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Unassigned |
Bug Description
The product release finder failed on the first use the an FTPWalker. This is probably an operational issue where the site or the port is blocked. Regardless of the connectivity issue, the PRF should not fail.
From the prf log:
2011-02-11 07:22:36 INFO Connecting to ftp.gnu.org
2011-02-11 07:22:36 ERROR Unhandled exception
From the tb in the librarian
File "/srv/launchpad
self.open()
File "/srv/launchpad
self.
File "/usr/lib/
self.sock = socket.
File "/usr/lib/
raise error, msg
error: [Errno 111] Connection refused
Related branches
- Brad Crittenden (community): Approve (code)
- Benji York (community): Approve (code*)
-
Diff: 257 lines (+40/-47)2 files modifiedlib/lp/registry/scripts/productreleasefinder/walker.py (+10/-4)
lib/lp/registry/tests/test_prf_walker.py (+30/-43)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
Fixed in stable r12371 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12371>.