bugtask search uses crazy left join to bug
Bug #714312 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
BugTask and Bug have a many:1 relationship - there are no bugtasks w/o a bug, so no need for a left join. Marking as high as we have consistent continual bug search performance issues and this is part of it.
Related branches
lp:~lifeless/launchpad/bug-661988
- Tim Penhey (community): Approve (code)
- Ian Booth (community): Approve (code*)
-
Diff: 446 lines (+72/-127)9 files modifiedlib/lp/bugs/browser/tests/test_buglisting.py (+2/-2)
lib/lp/bugs/configure.zcml (+1/-5)
lib/lp/bugs/interfaces/bugtask.py (+1/-0)
lib/lp/bugs/model/bugtask.py (+28/-43)
lib/lp/bugs/model/tests/test_bugtask.py (+18/-8)
lib/lp/bugs/tests/test_bugsearch_conjoined.py (+6/-2)
lib/lp/bugs/tests/test_bugtask_search.py (+5/-64)
lib/lp/registry/browser/milestone.py (+8/-0)
lib/lp/registry/browser/tests/test_milestone.py (+3/-3)
Changed in launchpad: | |
assignee: | nobody → Robert Collins (lifeless) |
Changed in launchpad: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12344 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12344>.