branch page looks like it links to branches, actually links to merge proposals
Bug #711647 reported by
Martin Pool
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
In the web view of revisions in a branch, eg <https:/
from _proposal_
or something like that.
Typically the mp will be in state 'merged' by the time we get here so seeing the state is not so useful. I think the main thing is to get to the mp; second most interesting maybe to see who approved it; third perhaps to see the votes (but often there are outdated votes and seeing them is noise.)
Related branches
lp:~wgrant/launchpad/more-trivialities
- Colin Watson (community): Approve
-
Diff: 200 lines (+54/-15)9 files modifiedlib/canonical/launchpad/icing/css/colours.css (+2/-1)
lib/lp/app/browser/tales.py (+3/-0)
lib/lp/bugs/browser/bugmessage.py (+2/-4)
lib/lp/bugs/templates/bug-comment-add-form.pt (+1/-1)
lib/lp/code/browser/tests/test_branch.py (+4/-2)
lib/lp/code/templates/branch-macros.pt (+2/-2)
lib/lp/registry/browser/tests/test_distribution.py (+33/-0)
lib/lp/registry/templates/distribution-index.pt (+6/-5)
lib/lp/registry/templates/milestone-index.pt (+1/-0)
Revision history for this message
| Martin Pool (mbp) wrote | #1 |
| Changed in launchpad: | |
| status: | Confirmed → Triaged |
| summary: |
- link from branch page to merge proposals + branch page looks like it links to branches, actually links to merge + proposals |
Revision history for this message
| John A Meinel (jameinel) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Ian pointed out that the link all already go to the mp, not to the branch. (They're all oopsing so I didn't see that.)
It's a inconsistent with the rest of lp for a link whose text is the branch name to actually go to an mp. One way to handle that would be to just hyperlink the whole phrase 'merged branch lp:....'