Expose BugSubscription.bug_notification_level in the API
Bug #704685 reported by
Graham Binns
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Graham Binns |
Bug Description
At the moment the WebService API version of IBug.subscribe() doesn't accept a level parameter. It needs to be able to do this before we can use it as part of the new advanced subscriptions work. Also, BugSubscription
Related branches
lp:~gmb/launchpad/expose-level-bug-704685
- Данило Шеган (community): Approve (code)
-
Diff: 154 lines (+54/-8)5 files modifiedlib/canonical/launchpad/components/apihelpers.py (+15/-0)
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+5/-0)
lib/lp/bugs/interfaces/bug.py (+8/-1)
lib/lp/bugs/interfaces/bugsubscription.py (+9/-7)
lib/lp/bugs/stories/webservice/xx-bug.txt (+17/-0)
lp:~gmb/launchpad/add-bnl-mutator-bug-704685
- Gary Poster (community): Approve
-
Diff: 11069 lines (+4084/-3501)141 files modifiedcronscripts/publishing/cron.germinate (+25/-9)
cronscripts/publishing/maintenance-check.py (+104/-58)
lib/canonical/launchpad/browser/vocabulary.py (+6/-5)
lib/canonical/launchpad/database/librarian.py (+2/-2)
lib/canonical/launchpad/doc/lazr-js-widgets.txt (+2/-2)
lib/canonical/launchpad/systemhomes.py (+1/-1)
lib/canonical/widgets/lazrjs.py (+48/-25)
lib/canonical/widgets/templates/inline-picker.pt (+7/-7)
lib/canonical/widgets/tests/test_inlineeditpickerwidget.py (+57/-0)
lib/lp/app/browser/configure.zcml (+6/-0)
lib/lp/app/browser/tales.py (+4/-1)
lib/lp/app/browser/tests/test_webservice.py (+4/-3)
lib/lp/app/browser/webservice.py (+15/-13)
lib/lp/app/javascript/picker.js (+51/-11)
lib/lp/bugs/configure.zcml (+29/-9)
lib/lp/bugs/doc/bugsubscription.txt (+33/-28)
lib/lp/bugs/doc/bugtask-search.txt (+9/-9)
lib/lp/bugs/doc/externalbugtracker-mantis-logging-in.txt (+8/-4)
lib/lp/bugs/doc/initial-bug-contacts.txt (+7/-7)
lib/lp/bugs/errors.py (+24/-0)
lib/lp/bugs/externalbugtracker/base.py (+0/-6)
lib/lp/bugs/externalbugtracker/mantis.py (+15/-14)
lib/lp/bugs/externalbugtracker/roundup.py (+1/-1)
lib/lp/bugs/externalbugtracker/tests/test_isolation.py (+6/-19)
lib/lp/bugs/externalbugtracker/trac.py (+1/-2)
lib/lp/bugs/interfaces/bug.py (+0/-13)
lib/lp/bugs/interfaces/bugsubscription.py (+9/-3)
lib/lp/bugs/interfaces/webservice.py (+0/-6)
lib/lp/bugs/javascript/bugtask_index.js (+51/-42)
lib/lp/bugs/model/apportjob.py (+6/-10)
lib/lp/bugs/model/bug.py (+1/-1)
lib/lp/bugs/model/bugjob.py (+5/-6)
lib/lp/bugs/model/bugsubscription.py (+4/-4)
lib/lp/bugs/model/bugsubscriptionfilter.py (+4/-4)
lib/lp/bugs/model/bugsubscriptionfilterimportance.py (+4/-4)
lib/lp/bugs/model/bugsubscriptionfilterstatus.py (+4/-4)
lib/lp/bugs/model/bugsubscriptionfiltertag.py (+4/-3)
lib/lp/bugs/model/bugtracker.py (+3/-3)
lib/lp/bugs/model/bugwatch.py (+2/-2)
lib/lp/bugs/scripts/checkwatches/bugwatchupdater.py (+0/-5)
lib/lp/bugs/security.py (+22/-2)
lib/lp/bugs/stories/patches-view/patches-view.txt (+1/-1)
lib/lp/bugs/stories/webservice/xx-bug.txt (+20/-9)
lib/lp/bugs/subscribers/bugactivity.py (+9/-0)
lib/lp/bugs/tests/bugs-emailinterface.txt (+1/-1)
lib/lp/bugs/tests/test_bugsubscription.py (+156/-0)
lib/lp/bugs/tests/test_bugtracker.py (+7/-5)
lib/lp/bugs/tests/test_duplicate_handling.py (+1/-1)
lib/lp/bugs/tests/test_subscribers.py (+52/-0)
lib/lp/code/browser/sourcepackagerecipe.py (+32/-2)
lib/lp/code/browser/sourcepackagerecipelisting.py (+8/-0)
lib/lp/code/browser/tests/test_recipebuildslisting.py (+11/-0)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+22/-14)
lib/lp/code/browser/tests/test_sourcepackagerecipelisting.py (+6/-0)
lib/lp/code/interfaces/branchrevision.py (+0/-2)
lib/lp/code/model/branch.py (+2/-3)
lib/lp/code/model/branchmergeproposal.py (+3/-3)
lib/lp/code/model/branchmergeproposaljob.py (+4/-5)
lib/lp/code/model/branchrevision.py (+1/-2)
lib/lp/code/model/sourcepackagerecipebuild.py (+4/-1)
lib/lp/code/model/tests/test_branchjob.py (+3/-1)
lib/lp/code/model/tests/test_branchmergeproposal.py (+21/-0)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+11/-3)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+2/-5)
lib/lp/registry/browser/configure.zcml (+0/-5)
lib/lp/registry/browser/distribution.py (+5/-3)
lib/lp/registry/browser/product.py (+9/-13)
lib/lp/registry/browser/tests/milestone-views.txt (+1/-1)
lib/lp/registry/doc/milestone.txt (+2/-2)
lib/lp/registry/doc/person.txt (+2/-2)
lib/lp/registry/interfaces/distributionmirror.py (+4/-0)
lib/lp/registry/interfaces/product.py (+2/-0)
lib/lp/registry/model/distribution.py (+43/-4)
lib/lp/registry/model/distributionmirror.py (+60/-18)
lib/lp/registry/model/mailinglist.py (+38/-41)
lib/lp/registry/model/nameblacklist.py (+4/-4)
lib/lp/registry/model/person.py (+4/-2)
lib/lp/registry/model/persontransferjob.py (+4/-5)
lib/lp/registry/model/product.py (+16/-0)
lib/lp/registry/model/structuralsubscription.py (+38/-35)
lib/lp/registry/templates/person-structural-subscriptions.pt (+2/-2)
lib/lp/registry/templates/product-packages.pt (+5/-3)
lib/lp/registry/tests/structural-subscription-target.txt (+2/-2)
lib/lp/registry/tests/test_distributionmirror.py (+26/-0)
lib/lp/registry/tests/test_mailinglist.py (+140/-2)
lib/lp/services/database/stormbase.py (+31/-0)
lib/lp/services/features/browser/configure.zcml (+15/-3)
lib/lp/services/features/browser/info.py (+58/-0)
lib/lp/services/features/browser/tests/test_feature_info.py (+159/-0)
lib/lp/services/features/flags.py (+41/-5)
lib/lp/services/features/scopes.py (+0/-5)
lib/lp/services/features/templates/feature-info.pt (+75/-0)
lib/lp/services/features/templates/feature-rules.pt (+5/-2)
lib/lp/services/features/tests/test_webapp.py (+6/-0)
lib/lp/services/features/webapp.py (+1/-95)
lib/lp/services/fields/__init__.py (+5/-2)
lib/lp/services/tests/test_utils.py (+15/-0)
lib/lp/services/utils.py (+13/-0)
lib/lp/soyuz/browser/archive.py (+1/-1)
lib/lp/soyuz/browser/build.py (+18/-11)
lib/lp/soyuz/browser/packagesearch.py (+2/-2)
lib/lp/soyuz/browser/tests/archive-views.txt (+4/-1)
lib/lp/soyuz/browser/tests/build-views.txt (+0/-430)
lib/lp/soyuz/browser/tests/test_build_views.py (+294/-0)
lib/lp/soyuz/browser/tests/test_builder_views.py (+2/-1)
lib/lp/soyuz/doc/binarypackagebuild.txt (+0/-1480)
lib/lp/soyuz/doc/build-estimated-dispatch-time.txt (+0/-178)
lib/lp/soyuz/doc/build-notification.txt (+0/-629)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+30/-0)
lib/lp/soyuz/model/archive.py (+3/-5)
lib/lp/soyuz/model/archivejob.py (+3/-3)
lib/lp/soyuz/model/binarypackagebuild.py (+51/-16)
lib/lp/soyuz/model/distributionjob.py (+4/-4)
lib/lp/soyuz/model/distroarchseries.py (+28/-17)
lib/lp/soyuz/model/publishing.py (+3/-3)
lib/lp/soyuz/scripts/ppa_apache_log_parser.py (+4/-1)
lib/lp/soyuz/scripts/tests/germinate-test-data/mock-bin/germinate (+5/-0)
lib/lp/soyuz/scripts/tests/germinate-test-data/mock-bin/lockfile (+8/-0)
lib/lp/soyuz/scripts/tests/germinate-test-data/mock-lp-root/scripts/ftpmaster-tools/lp-query-distro.py (+27/-0)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+31/-0)
lib/lp/soyuz/scripts/tests/test_cron_germinate.py (+228/-0)
lib/lp/soyuz/scripts/tests/test_ppa_apache_log_parser.py (+20/-5)
lib/lp/soyuz/stories/soyuz/xx-build-redirect.txt (+0/-8)
lib/lp/soyuz/stories/webservice/xx-builds.txt (+8/-1)
lib/lp/soyuz/templates/build-index.pt (+2/-2)
lib/lp/soyuz/tests/test_archive.py (+5/-5)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+8/-7)
lib/lp/soyuz/tests/test_build.py (+411/-0)
lib/lp/soyuz/tests/test_build_depwait.py (+120/-0)
lib/lp/soyuz/tests/test_build_notify.py (+369/-0)
lib/lp/soyuz/tests/test_build_privacy.py (+87/-0)
lib/lp/soyuz/tests/test_build_set.py (+208/-0)
lib/lp/soyuz/tests/test_build_start_estimation.py (+88/-0)
lib/lp/soyuz/tests/test_doc.py (+0/-10)
lib/lp/soyuz/tests/test_hasbuildrecords.py (+184/-9)
lib/lp/testing/_webservice.py (+1/-1)
lib/lp/testing/factory.py (+29/-1)
lib/lp/testing/tests/test_standard_test_template.py (+1/-1)
lib/lp/translations/interfaces/translationimportqueue.py (+3/-4)
standard_template.py (+1/-2)
versions.cfg (+1/-1)
lp:~gmb/launchpad/fix-query-counting-for-bnl-api
- Graham Binns (community): Approve
-
Diff: 507 lines (+309/-18)13 files modifiedlib/canonical/launchpad/components/apihelpers.py (+15/-0)
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+5/-0)
lib/lp/bugs/configure.zcml (+2/-2)
lib/lp/bugs/interfaces/bug.py (+8/-1)
lib/lp/bugs/interfaces/bugsubscription.py (+16/-8)
lib/lp/bugs/security.py (+22/-2)
lib/lp/bugs/stories/webservice/xx-bug.txt (+29/-1)
lib/lp/bugs/subscribers/bugactivity.py (+9/-0)
lib/lp/bugs/tests/test_bugsubscription.py (+148/-0)
lib/lp/bugs/tests/test_subscribers.py (+52/-0)
lib/lp/testing/_webservice.py (+1/-1)
lib/lp/testing/tests/test_standard_test_template.py (+1/-1)
standard_template.py (+1/-2)
summary: |
- The level parameter on IBug.subscribe() should be exposed in the WS API + Expose BugSubscription.bug_notification_level in the API |
description: | updated |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: | removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12272 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12272>.