Translation approval stumbles over divergence

Bug #702832 reported by Jeroen T. Vermeulen
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Jeroen T. Vermeulen

Bug Description

Approving a translation message seems to break when divergence is involved (and therefore the message needs to be cloned).

The reason is that POTMsgSet._setTranslation documents its potranslations parameter as being a list of POTranslations, but in these cases it calls _makeTranslation which expects a dict.

Other call sites actually do seem to pass a dict, but _approveTranslation passes a list. We didn't notice this because it's fairly unusual for _approveTranslation to create a new message, and unit tests would pass a list instead. We should update the documentation and just use a dict in all cases.

OOPS-1839EA1279, OOPS-1839EA1302, OOPS-1839EA1310, OOPS-1839ED1147, OOPS-1839EE1253

Tags: oops qa-ok

Related branches

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers