loggerhead does not handle incompatible repositories (CHKInventoryRepository)

Reported by Robert Collins on 2011-01-10
64
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Unassigned
loggerhead
Critical
Unassigned

Bug Description

When a branch is stacked on on a branch with an incompatible format, the user cannot diagnose that this is happening via loggerhead:

OOPS-1834CBB6546 -
Date: 2011-01-08 19:41:35
http://bazaar.launchpad.net/~mgedmin/gtimelog/app-indicator (fixed now)

IncompatibleRepositories: CHKInventoryRepository('lp-47845825519504:///~gtimelog-dev/gtimelog/trunk/.bzr/repository') is not compatible with KnitPackRepository('lp-47845825519504:///~mgedmin/gtimelog/trunk/.bzr/repository') different serializers

I think that this shouldn't throw up through the stack - it should show an error page, the involved urls and a pointer to docs or some such.

Martin Pool (mbp) wrote :

I'm not sure this shouldn't throw an oops: it indicates that the user isn't able to get the data out of the branch, and this is something we could at least try to fix. (Either by cross-format stacking, or by upgrading the branches for them.)

On Tue, Jan 11, 2011 at 12:27 PM, Martin Pool <email address hidden> wrote:
> I'm not sure this shouldn't throw an oops: it indicates that the user
> isn't able to get the data out of the branch, and this is something we
> could at least try to fix.  (Either by cross-format stacking, or by
> upgrading the branches for them.)

We could record an oops, but I don't think we want to show the oops
screen to the user when (often) they can fix the situation themselves.
(Certainly for local installs of loggerhead the local user can fix it,
and when looking at ones own branch in launchpad).

Also OOPS are rather inefficient for generating a list of all branches
that need fixing : we can do that better with an analysis script for
the branch hosting area.

Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
summary: - loggerhead does not handle incompatible repositories exception
+ loggerhead does not handle incompatible repositories
+ (CHKInventoryRepository)
description: updated
Max Kanat-Alexander (mkanat) wrote :

Okay, so it sounds like the best fix would be for launchpad to have an analysis script, instead of having a custom exception handler in loggerhead to deal with this specific situation. Loggerhead itself normally actually shows the user the error it received--it's only on Launchpad that it hides the error. So I think a launchpad-specific resolution would be more appropriate here, and this probably does not need any work on loggerhead.

Changed in loggerhead:
status: Triaged → Won't Fix
Robert Collins (lifeless) wrote :

I disagree. Even for standalone loggerhead installs we can do better than barfing.

Changed in loggerhead:
status: Won't Fix → Triaged
importance: High → Critical
William Grant (wgrant) on 2012-10-22
tags: added: codebrowse
William Grant (wgrant) on 2012-10-22
tags: added: bzr
piotr zimoch (ebytyes) on 2013-06-14
Changed in launchpad:
status: Triaged → New
status: New → Incomplete
status: Incomplete → Opinion
status: Opinion → Invalid
status: Invalid → Confirmed
status: Confirmed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Changed in loggerhead:
status: Triaged → New
status: New → Incomplete
status: Incomplete → Opinion
status: Opinion → Invalid
status: Invalid → Confirmed
status: Confirmed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Changed in ubuntu:
status: New → Incomplete
status: Incomplete → Opinion
status: Opinion → Invalid
status: Invalid → Confirmed
status: Confirmed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
William Grant (wgrant) on 2013-06-14
no longer affects: ubuntu
Changed in launchpad:
status: Fix Released → Triaged
Changed in loggerhead:
status: Fix Released → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers