BinaryPackageBuild:+index times out with many binary packages

Reported by William Grant on 2011-01-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Jeroen T. Vermeulen

Bug Description

As seen in OOPS-1835H1505 (https://launchpad.net/~libreoffice/+archive/ppa/+build/2120859), BinaryPackageBuild:+index issues three queries for each binary package. Reducing this to one for each is trivial; getting it constant is slightly harder.

Related branches

Robert Collins (lifeless) wrote :

high per zero-oops-policy

Changed in launchpad:
importance: Low → High
summary: - BinaryPackageBuild:+index scales badly
+ BinaryPackageBuild:+index times out with many binary packages
Changed in launchpad:
importance: High → Critical
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Julian Edwards (julian-edwards)
Changed in launchpad:
assignee: Julian Edwards (julian-edwards) → Jeroen T. Vermeulen (jtv)
Changed in launchpad:
status: In Progress → Fix Committed
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.02
tags: added: qa-needstesting
Robert Collins (lifeless) wrote :

The fix for this seems to do the (possibly) expensive part twice - in future iterations I'd consider generating the filtered set to a temp table and doing the later two queries from that. OTOH we have no data on how this will really perform yet, but I expect it will be a substantial win over current code regardless.

tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless) wrote :

Seems pretty happy on qastaging

Robert Collins (lifeless) wrote :

55 queries in 2.6 seconds on the referenced url - nice one!

Changed in launchpad:
status: Fix Committed → Fix Released
Jeroen T. Vermeulen (jtv) wrote :

Robert: thanks for taking care of the Q/A on this one, and my apologies for letting it slide for so long.

And yes, it's clear that we can do better yet. That was a benefit/turnaround tradeoff we had to make.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers