If all commit hooks fail in our tarmac fork, the tests are still run
Bug #693595 reported by
Gary Poster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
(lp:~launchpad/tarmac/lp-tarmac)
The commit message checker plugin tried to connect to a hook that did not exist. When I tried using the closest equivalent, a pre-commit-hook, I saw that, even if all merge proposals are rejected by this kind of hook, the tests are still run. We shouldn't do that.
Related branches
lp:~gary/tarmac/fix693595
- Diogo Matsubara (community): Approve
-
Diff: 364 lines (+157/-90)4 files modifiedtarmac/bin/commands.py (+49/-55)
tarmac/branch.py (+34/-20)
tarmac/pidfile.py (+36/-12)
tarmac/tests/test_commands.py (+38/-3)
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
