Test suite fails if previous run did not tear down Librarian fully.

Bug #692872 reported by Stuart Bishop
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Stuart Bishop

Bug Description

If the Librarian is left running by a test run, or if the Librarian pid file is left in place, future test runs will fail.

This is caused because we use a static path for librarian data in test runs. We should allocate them dynamically.

Infrastructure work to permit this has been done - see the attached branch, which is landable - but doesn't quite go the final step - it was getting too big.

Related branches

Revision history for this message
Robert Collins (lifeless) wrote :

I removed code that did this because it was masking terrible fixture management issues: we were running a librarian per test runner instance - which was many in a full run - because of the zope testrunner reinvocation logic.

My librarian branch, if landed, should take us a long way to unique librarian instances per run with no interactions with the remains of the previous run.

Changed in launchpad:
status: New → Won't Fix
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 692872] Re: Test suite fails if previous run did not tear down Librarian fully.

On Tue, Dec 21, 2010 at 8:04 PM, Robert Collins
<email address hidden> wrote:
> I removed code that did this because it was masking terrible fixture
> management issues: we were running a librarian per test runner instance
> - which was many in a full run - because of the zope testrunner
> reinvocation logic.

I wasn't entirely clear there: we had N concurrent librarians running
because of the masked issues. And this would routinely lead to
buildbot failing with stale librarians. (they all shared a pid file,
so when the second one started, the first became lost).

Changed in launchpad:
status: Won't Fix → Triaged
status: Triaged → In Progress
importance: Undecided → High
Revision history for this message
Stuart Bishop (stub) wrote :

lp:~lifeless/launchpad/librarian fixes the issue in a better way.

description: updated
Changed in launchpad:
importance: High → Medium
description: updated
Stuart Bishop (stub)
Changed in launchpad:
importance: Medium → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in launchpad:
assignee: nobody → Stuart Bishop (stub)
milestone: none → 11.02
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-untestable
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.