Upload processor attempts to verify hashes against expired files

Bug #687662 reported by William Grant
46
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
William Grant

Bug Description

devel r12009 altered the upload processor to use Archive.getFileByName instead of Distribution.getFileByName. The former returns expired files, while the latter does not. Expired LFAs have no LFC, so the content.md5 check fails like this:

 Unhandled exception processing upload: 'NoneType' object has no attribute 'md5'

lp:~wgrant/launchpad/bug-522800-getFileByName should fix this by preventing Archive.getFileByName from returning expired files.

Tags: lp-soyuz qa-ok

Related branches

Changed in soyuz:
importance: Undecided → High
assignee: nobody → William Grant (wgrant)
status: New → In Progress
Revision history for this message
Volodymyr Kolesnykov (sjinks) wrote :

Is there any workaround?

Ant upload to PPA fails with "Rejected: Unhandled exception processing upload: 'NoneType' object has no attribute 'md5'"

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 687662] Re: Upload processor attempts to verify hashes against expired files

On Friday 10 December 2010 13:18:38 you wrote:
> Is there any workaround?
>
> Ant upload to PPA fails with "Rejected: Unhandled exception processing
> upload: 'NoneType' object has no attribute 'md5'"

You need to upload a new orig file instead of depending on one that was
previously uploaded that since expired.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
Revision history for this message
Volodymyr Kolesnykov (sjinks) wrote :

> You need to upload a new orig file instead of depending on one that was previously uploaded that since expired.

Tried both debuild -S -sa and debuild -S -sd, both get rejected with that error.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

I tried uploading with both -sa and -sd, and the problem occurs in both the ways. Any workaround? I seem to be having the same case as vladimir.

Revision history for this message
Glen Ditchfield (gjditchfield) wrote :

> You need to upload a new orig file instead of depending on one that was previously uploaded that since expired.

I worked around the problem by renaming the orig file, which I could do because the upstream version name wasn't crucial.
* renamed alephone_20100424.orig.tar.gz to alephone_20100424x.orig.tar.gz
* changed the version line at the top of debian/changelog to
  alephone (20100424x-0~maverick3) maverick; urgency=low
* rebuilt the package with "debuild ... -S -si ..."

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

My latest attempt a few hours ago was accepted, so it seems to be working now.

Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.