Launchpad itself

No ability to manually trigger a build 'like the daily build system'

Bug #687623 reported by Robert Collins
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Ian Booth
Launchpad itself 11.03

Bug Description

As it says on the box. See bug 682923 for conversation around this - but its about the dialog UI, this is about the functionality.

Related branches

lp:~wallyworld/launchpad/recipe-build-now
Tim Penhey (community): Approve (code)
Henning Eggers (community): Approve (ui)
Diff: 1179 lines (+498/-134)
11 files modified
lib/canonical/launchpad/icing/icon-sprites.positioning (+56/-52)
lib/canonical/launchpad/icing/style-3-0.css.in (+8/-5)
lib/lp/code/browser/configure.zcml (+6/-0)
lib/lp/code/browser/sourcepackagerecipe.py (+140/-36)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+83/-0)
lib/lp/code/interfaces/sourcepackagerecipe.py (+4/-0)
lib/lp/code/javascript/requestbuild_overlay.js (+118/-27)
lib/lp/code/model/sourcepackagerecipe.py (+14/-0)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+36/-2)
lib/lp/code/windmill/tests/test_recipe_request_build.py (+26/-12)
lib/lp/testing/__init__.py (+7/-0)
Revision history for this message
Aaron Bentley (abentley) wrote :

I think this could be an attractive nuisance. If daily builds are enabled, running a manual build with the same parameters causes pain: Bug #684515

Revision history for this message
Jonathan Lange (jml) wrote :

Could we change the system so that a manually triggered build counts as the daily build for that day?

Wanting a build now with the same parameters as the daily doesn't seem fundamentally wrong. It seems that the problem is that the daily build will go ahead anyway.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 687623] Re: No ability to manually trigger a build 'like the daily build system'

On Thu, Dec 23, 2010 at 5:50 AM, Jonathan Lange <email address hidden> wrote:
> Could we change the system so that a manually triggered build counts as
> the daily build for that day?

If no new commits have been done, that would make sense to me.

> Wanting a build now with the same parameters as the daily doesn't seem
> fundamentally wrong. It seems that the problem is that the daily build
> will go ahead anyway.

We could detect same-details and do a no-change-rebuild transform to
the package (as documented in the Ubuntu developer docs for rebuilding
failed packages).

Tim Penhey (thumper)
tags: added: recipe
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Ian Booth (wallyworld) wrote :

As discussed with Tim, recipes which are scheduled to be built daily will get a "Build now" action to manually initiate the daily build. The action will only be available if the recipe is stale and the user has upload permissions to the recipe's daily build archive. The action performs the same operation as the request_daily_builds job run by the cron script.

Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12441 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12441>.

Changed in launchpad:
assignee: nobody → Ian Booth (wallyworld)
milestone: none → 11.03
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.