bundle-merge command does not handle TarmacMergeErrors properly
Bug #686565 reported by
Māris Fogels
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Māris Fogels | ||
Bug Description
The bundle-merge and merge commands in lp:~launchpad/tarmac/lp-tarmac do not handle TarmacMergeErrors properly. If a plugin raises one of these errors, the program leaves the merge proposal untouched.
If a plugin fails the program should correctly set the status to 'Needs Review' as well as adding a comment about the failure's reason to the proposal.
Related branches
lp:~mars/tarmac/fix-merge-error-updates-proposals
- Diogo Matsubara (community): Approve
-
Diff: 285 lines (+166/-19)4 files modifiedtarmac/bin/commands.py (+18/-5)
tarmac/branch.py (+14/-12)
tarmac/tests/test_branch.py (+35/-0)
tarmac/tests/test_commands.py (+99/-2)
| Changed in launchpad: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
