doctest construction generates duplicate test ids
Bug #682772 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Brad Crittenden |
Bug Description
See bug 682771 for why this matters.
Doctest construction needs to use the relative path to the file rather than just its basename, that way things will be unique.
Related branches
lp:~bac/zope.testing/list-tests
- Gary Poster (community): Approve
-
Diff: 101 lines (+10/-11)4 files modifiedsetup.py (+1/-1)
src/zope/testing/testrunner/find.py (+7/-7)
src/zope/testing/testrunner/formatter.py (+2/-2)
src/zope/testing/testrunner/listing.py (+0/-1)
lp:~bac/launchpad/bug-682772
- Gary Poster (community): Approve
-
Diff: 578 lines (+116/-86)18 files modifiedlib/lp/answers/tests/test_doc.py (+6/-3)
lib/lp/bugs/tests/test_bugcontact.py (+5/-1)
lib/lp/bugs/tests/test_buglinktarget.py (+5/-3)
lib/lp/bugs/tests/test_bugtarget.py (+5/-1)
lib/lp/bugs/tests/test_doc.py (+13/-2)
lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+5/-1)
lib/lp/coop/answersbugs/tests/test_doc.py (+14/-13)
lib/lp/registry/tests/test_distribution.py (+4/-3)
lib/lp/registry/tests/test_distroseries.py (+27/-15)
lib/lp/registry/tests/test_doc.py (+3/-0)
lib/lp/services/verification/browser/tests/test_logintoken_corner_cases.py (+0/-25)
lib/lp/services/webservice/tests/test_doc.py (+2/-1)
lib/lp/soyuz/tests/test_doc.py (+1/-0)
lib/lp/testing/pages.py (+4/-3)
lib/lp/testing/systemdocs.py (+14/-11)
lib/lp/testing/tests/test_inlinetests.py (+1/-1)
lib/lp/testing/tests/test_systemdocs.py (+2/-2)
versions.cfg (+5/-1)
Changed in launchpad-foundations: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in launchpad: | |
importance: | Medium → Low |
Changed in launchpad: | |
assignee: | nobody → Brad Crittenden (bac) |
status: | Triaged → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Further:
lifeless: testtools. clone_test_ with_new_ id can be used to assign a unique id. create the test (duplicative id); then clone it to a new id, and add the resulting new-id test into the suite, let the original get gc'd.
bac: are you suggesting doing that in filter_tests or in the various test_doc files?
lifeless: I was assuming local-to- the-duplicative ness with a sanity-check in the global test_suite() constructor to enforce uniqueness