Need a closed team and user vocabulary and picker
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
High
|
Curtis Hovey | ||
Bug Description
There are several cases where Launchpad must prevent users from selecting a team with an open subscription policy because it compromises security or discloses information. The person picker and forms need a vocabulary that is composed on closed teams (restricted and moderated), and users. The picker/vocabulary is needed is needed in:
1. closed team owner role
2. closed team +addmember
3. moderated team +proposemember
Related branches
- Gavin Panella (community): Approve on 2010-12-02
-
Diff: 762 lines (+264/-144)15 files modifiedlib/canonical/launchpad/vocabularies/dbobjects.py (+2/-0)
lib/canonical/launchpad/webapp/vocabulary.py (+5/-1)
lib/canonical/widgets/popup.py (+21/-13)
lib/lp/answers/vocabulary.py (+1/-2)
lib/lp/app/widgets/tests/test_popup.py (+43/-0)
lib/lp/blueprints/vocabularies/specificationdependency.py (+1/-0)
lib/lp/code/vocabularies/branch.py (+1/-0)
lib/lp/registry/browser/configure.zcml (+1/-1)
lib/lp/registry/browser/person.py (+7/-0)
lib/lp/registry/browser/tests/test_team.py (+14/-0)
lib/lp/registry/doc/vocabularies.txt (+1/-93)
lib/lp/registry/javascript/team.js (+2/-2)
lib/lp/registry/templates/team-portlet-membership.pt (+4/-2)
lib/lp/registry/tests/test_person_vocabularies.py (+99/-18)
lib/lp/registry/vocabularies.py (+62/-12)
| Robert Collins (lifeless) wrote : | #1 |
| Curtis Hovey (sinzui) wrote : | #2 |
I am not sure how we would do that with vocabularies, they return one set of data. The picker could be reimplemented to do an exact look + a search as we do on global search. hmm. Doing so would fix several related vocabulary/picker bugs where exact matches are not top listed (bug 419531). Worse still users get timeouts search for terms that do have an exact match (bug 541979).
| description: | updated |
Fixed in stable r12018 <http://
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
I have a suggestion here - if someone puts in an exact match for an open team, we should show-and-