Builder failure_count should be reset when marking it as "ok"
Bug #680442 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Julian Edwards | ||
Bug Description
If we don't then if the initial dispatch fails, the builder will also be immediately failed.
Related branches
lp:~julian-edwards/launchpad/reset-fail-count-bug-680442
- Jelmer Vernooij (community): Approve
-
Diff: 126 lines (+29/-6)5 files modifiedlib/lp/buildmaster/manager.py (+1/-0)
lib/lp/buildmaster/model/builder.py (+13/-3)
lib/lp/buildmaster/tests/test_builder.py (+9/-1)
lib/lp/buildmaster/tests/test_manager.py (+3/-0)
lib/lp/soyuz/model/buildpackagejob.py (+3/-2)
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: buildfarm |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| Changed in soyuz: | |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in soyuz: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
In addition, the count needs to be reset in the manager if the job is failed, for the same reason.