gina should set spr.changelog

Bug #680382 reported by Steve Kowalik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Steve Kowalik

Bug Description

When new source packages are imported with Gina, she should upload the changelog to the librarian, and link it to the created SPR.

Related branches

Steve Kowalik (stevenk)
tags: added: derivation
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in soyuz:
assignee: nobody → Steve Kowalik (stevenk)
milestone: none → 10.12
tags: added: qa-needstesting
Changed in soyuz:
status: New → Fix Committed
Revision history for this message
Steve Kowalik (stevenk) wrote :

I have sucessfully QA'd this on dogfood, by creating a small Debian mirror of sid and running gina over it.

Picking out some of the new sources imported during the run, I wrote the following script:

from zope.component import getUtility
from lp.registry.interfaces.distribution import IDistributionSet

packages = ('haskell-hxt-charproperties', 'initramfs-tools', 'jackd2', 'libtext-sass-perl', 'python-gnutls', 'system-config-lvm', 'unscd', 'xserver-xorg-video-intel')

sid = getUtility(IDistributionSet)['debian']['sid']

for pkg in packages:
 spr = sid.getSourcePackage(pkg).currentrelease
 print "%ch = spr.changelog
 if ch is None:
  print "No changelog"
 else:
  print ch.getURL()

Which produced the following output:
haskell-hxt-charproperties 9.0.0-1
https://librarian.dogfood.launchpad.net/57530744/changelog
initramfs-tools 0.97
No changelog
jackd2 1.9.5~dfsg-17
No changelog
libtext-sass-perl 0.5-1
No changelog
python-gnutls 1.2.0-2
https://librarian.dogfood.launchpad.net/57530830/changelog
system-config-lvm 1.1.15-1
https://librarian.dogfood.launchpad.net/57530846/changelog
unscd 0.47-1
https://librarian.dogfood.launchpad.net/57530858/changelog
xserver-xorg-video-intel 2:2.8.1-1
No changelog

It seems my script is naive, and doesn't get the latest version, so not all of them have a changelog set. However, I checked all of them that did have one set, and it has hit the librarian correctly.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote :

Deployed to nodowntime; is this sufficient?

Steve Kowalik (stevenk)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.