| 2010-11-19 00:12:23 |
Alex Chiang |
bug |
|
|
added bug |
| 2010-11-19 02:55:43 |
Robert Collins |
affects |
launchpad |
launchpad-foundations |
|
| 2010-11-19 02:55:56 |
Robert Collins |
launchpad-foundations: importance |
Undecided |
High |
|
| 2010-11-19 04:18:22 |
Curtis Hovey |
launchpad-foundations: status |
New |
Triaged |
|
| 2010-11-19 18:57:36 |
Francis J. Lacoste |
launchpad-foundations: status |
Triaged |
In Progress |
|
| 2010-11-19 18:57:45 |
Francis J. Lacoste |
launchpad-foundations: assignee |
|
Canonical LOSAs (canonical-losas) |
|
| 2010-11-26 07:01:29 |
Robert Collins |
summary |
restricted librarian broken, content decoding error |
apache/squid breaks restricted librarian on urls with percent encoded characters. |
|
| 2010-11-26 07:13:35 |
Robert Collins |
description |
I'm trying to access files related to packages in Launchpad and it is breaking in strange ways in both Chrome and Firefox.
The following links all break for me:
https://edge.launchpad.net/~oem-archive/+archive/budapest/+files/pulseaudio_1%3A0.9.22~0.9.21%2Bstable-queue-32-g8478-0ubuntu14budapest10_1%3A0.9.22~0.9.21%2Bstable-queue-32-g8478-0ubuntu14budapest11.diff.gz
https://edge.launchpad.net/~oem-archive/+archive/budapest/+build/2053204/+files/buildlog_ubuntu-lucid-amd64.pulseaudio_1%3A0.9.22~0.9.21%2Bstable-queue-32-g8478-0ubuntu14budapest11_FAILEDTOBUILD.txt.gz
https://edge.launchpad.net/~oem-archive/+archive/budapest/+build/2053205/+files/buildlog_ubuntu-lucid-i386.pulseaudio_1%3A0.9.22~0.9.21%2Bstable-queue-32-g8478-0ubuntu14budapest11_FAILEDTOBUILD.txt.gz
I get errors like this in Chrome:
--------------------
The webpage at https://i59295771.restricted.launchpadlibrarian.net/59295771/buildlog_ubuntu-lucid-i386.pulseaudio_1%3A0.9.22~0.9.21%2Bstable-queue-32-g8478-0ubuntu14budapest11_FAILEDTOBUILD.txt.gz?token=c9b0ec586621d5b4f9118e6e278e1d4c might be temporarily down or it may have moved permanently to a new web address.
More information on this error
Below is the original error message
Error 330 (net::ERR_CONTENT_DECODING_FAILED): Unknown error.
--------------------
And Firefox says:
------------------------
Content Encoding Error
The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.
* Please contact the website owners to inform them of this problem.
------------------- |
There are two issues - firstly restricted urls with % encoded characters - e.g. + -> %2B return 404's, and secondly those 404's have incorrect content encoding headers due to bug 681675.
We've confirmed that the librarian itself handles % encoded characters correctly (yay telnet/nc). This leaves squid or apache as the culprit. We've also established that the content-encoding overrides are not to blame. |
|
| 2010-11-26 08:56:45 |
Robert Collins |
bug watch added |
|
http://issues.apache.org/bugzilla/show_bug.cgi?id=15207 |
|
| 2010-11-26 10:19:24 |
Robert Collins |
bug watch added |
|
http://issues.apache.org/bugzilla/show_bug.cgi?id=32328 |
|
| 2010-11-26 10:21:19 |
Robert Collins |
summary |
apache/squid breaks restricted librarian on urls with percent encoded characters. |
apache breaks restricted librarian on urls with percent encoded characters. |
|
| 2010-11-26 10:26:56 |
Robert Collins |
description |
There are two issues - firstly restricted urls with % encoded characters - e.g. + -> %2B return 404's, and secondly those 404's have incorrect content encoding headers due to bug 681675.
We've confirmed that the librarian itself handles % encoded characters correctly (yay telnet/nc). This leaves squid or apache as the culprit. We've also established that the content-encoding overrides are not to blame. |
There are two issues - firstly restricted urls with % encoded characters - e.g. + -> %2B return 404's, and secondly those 404's have incorrect content encoding headers due to bug 681675.
We've confirmed that the librarian itself handles % encoded characters correctly (yay telnet/nc).
And we've confirmed that squid passes them through correctly.
This leaves apache as the culprit.
We've also established that the content-encoding overrides are not to blame - the problem can be reproduced simply with a private bug with an attachment called 'foo+bar.txt'.
|
|
| 2011-01-11 17:35:05 |
Robert Collins |
summary |
apache breaks restricted librarian on urls with percent encoded characters. |
restricted librarian urls give a 404 if normalised (e.g. by apache, chromium, often shows up on private PPA build logs) |
|
| 2011-01-11 17:35:17 |
Robert Collins |
launchpad: assignee |
Canonical LOSAs (canonical-losas) |
|
|
| 2011-01-11 17:35:21 |
Robert Collins |
launchpad: status |
In Progress |
Triaged |
|
| 2011-01-11 17:38:30 |
Robert Collins |
description |
There are two issues - firstly restricted urls with % encoded characters - e.g. + -> %2B return 404's, and secondly those 404's have incorrect content encoding headers due to bug 681675.
We've confirmed that the librarian itself handles % encoded characters correctly (yay telnet/nc).
And we've confirmed that squid passes them through correctly.
This leaves apache as the culprit.
We've also established that the content-encoding overrides are not to blame - the problem can be reproduced simply with a private bug with an attachment called 'foo+bar.txt'.
|
The restricted librarian generates non-canonical form urls, these can then be changed by canonicalising clients / intermediaries. Changing the restricted librarian urls causes the token to not match and a 404 - file not found - is returned to the client.
Apache without the nocanon config option will canonicalise, and some browsers like Chrome are known to canonicalise too.
Fairly simple file names - 'foo+bar.txt' - will show this problem.
Workarounds
===========
Use Firefox, run apache with nocanon on proxypass rules. We are currently doing the latter in the Canonical datacentre.
Proposed solutions
==================
* Change the url generation in Launchpad to be canonicalised, then canonicalisation will not change the url and things will Just Work. |
|
| 2011-01-26 13:58:32 |
Benji York |
bug |
|
|
added subscriber Benji York |
| 2011-10-17 19:28:38 |
Andreas Hasenack |
bug |
|
|
added subscriber Andreas Hasenack |
| 2011-11-30 04:40:01 |
Herb McNew |
bug |
|
|
added subscriber Herb McNew |
| 2012-01-06 07:58:51 |
Robert Collins |
tags |
lp-foundations |
easy lp-foundations |
|
| 2012-03-21 22:26:15 |
Dustin Kirkland |
bug |
|
|
added subscriber Dustin Kirkland |
| 2012-12-12 21:24:56 |
Nelson Elhage |
bug |
|
|
added subscriber Nelson Elhage |
| 2013-01-16 22:01:45 |
Adam Stokes |
bug |
|
|
added subscriber Adam Stokes |
| 2015-05-13 01:20:01 |
Shih-Yuan Lee |
bug |
|
|
added subscriber Shih-Yuan Lee |
| 2015-12-09 06:28:03 |
Launchpad Janitor |
branch linked |
|
lp:~wgrant/launchpad/bug-677270 |
|
| 2015-12-10 01:45:27 |
Launchpad QA Bot |
launchpad: assignee |
|
William Grant (wgrant) |
|
| 2015-12-10 01:45:29 |
Launchpad QA Bot |
tags |
easy lp-foundations |
easy lp-foundations qa-needstesting |
|
| 2015-12-10 01:45:30 |
Launchpad QA Bot |
launchpad: status |
Triaged |
Fix Committed |
|
| 2015-12-11 03:23:18 |
William Grant |
tags |
easy lp-foundations qa-needstesting |
easy lp-foundations qa-ok |
|
| 2016-01-08 09:59:58 |
Colin Watson |
launchpad: status |
Fix Committed |
Fix Released |
|
