Relax-NG validity error : Element hardware failed to validate

Bug #676988 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Unassigned

Bug Description

As seen OOPS-1782C2286 a parsing error occurred processing hwdb submissions.

There's no traceback or exception raised, only the following logged as the request variables:

    * <oops-message-4>: Parsing submission a288f037ba9baf328477e09c7d3d5cd0: Relax NG validation failed. /tmp/tmpGuSPp3:6 ... Pp3:6780: element hardware: Relax-NG validity error : Element hardware failed to validate content
    * path: /srv/launchpad.net/production/launchpad/cronscripts/process-hwdb-submissions.py
    * script_name: hwdbsubmissions

Tags: hwdb lp-bugs oops

Related branches

Revision history for this message
Robert Collins (lifeless) wrote :

High per ZOP.

Changed in malone:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Ursula Junque (ursinha) wrote :

Updating to Critical according to the updated ZOP

Changed in launchpad:
importance: High → Critical
Revision history for this message
j.c.sackett (jcsackett) wrote :

This is a result of bad data being send in as a submission.

In lib/lp/hardwardb/scripts/hwdbsubmission.py, @ line 172, we have:

{{{
        if not validator.validate(submission):
            self._logError(
                'Relax NG validation failed.\n%s' % validator.error_log,
                submission_key)
            return None
}}}

The data listed in the OOPS (/59205184/ubuntu.xml.bz2, in the OOPS report) was bad data, so naturally it doesn't validate. We shouldn't be raising an OOPS for this, we should just log it and move on.

Revision history for this message
Curtis Hovey (sinzui) wrote :

I reported a bug 746689 in /checkbox about the invalid data.

j.c.sackett (jcsackett)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → j.c.sackett (jcsackett)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

This doesn't break anything, but doesn't seem to fix the bug. See OOPS-1927QS260 for an example of the continued OOPSing.

tags: added: qa-nok
removed: qa-needstesting
tags: added: qa-ok
removed: qa-nok
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → In Progress
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: 11.04 → 11.05
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: 11.05 → 11.06
William Grant (wgrant)
tags: removed: qa-ok
j.c.sackett (jcsackett)
Changed in launchpad:
assignee: j.c.sackett (jcsackett) → nobody
Changed in launchpad:
status: In Progress → Triaged
Revision history for this message
Abel Deuring (adeuring) wrote :

This is the same as bug 835103, which was fixed in r13822 and r13870

Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.