Launchpad itself

Code still using POTMsgSet.potemplate

Bug #675426 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 10.12

Bug Description

Before we can fix bug 401633, we still have to remove a few references to POTMsgSet.potemplate from the codebase.

Related branches

lp:~jtv/launchpad/bug-675426
Graham Binns (community): Approve (code)
Diff: 152 lines (+7/-52)
6 files modified
lib/lp/translations/browser/pofile.py (+1/-1)
lib/lp/translations/browser/tests/pofile-views.txt (+2/-2)
lib/lp/translations/browser/tests/translationmessage-views.txt (+0/-42)
lib/lp/translations/doc/potmsgset.txt (+3/-3)
lib/lp/translations/interfaces/potmsgset.py (+0/-2)
lib/lp/translations/model/potmsgset.py (+1/-2)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

A bunch of these can be found with:

$ grep -rIis 'potmsgset[^ ()]*\.potemplate' lib/lp/translations/

Revision history for this message
Данило Шеган (danilo) wrote :

I can only see it used in scripts which I thought we already removed (at least on the recife branch) and in tests (which would need fixing). And one trivial occurrence in pofile.py.

Changed in rosetta:
status: New → Triaged
importance: Undecided → High
tags: added: tech-debt
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

More effective search:

$ grep -rIis 'msgset[^ (.]*\.potemplate' lib/lp lib/canonical/ scripts/ cronscripts/

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Also, there's one in POTMsgSet.dismissAllSuggestions, disguised as self.potemplate.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11929 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11929>.

Changed in rosetta:
assignee: nobody → Jeroen T. Vermeulen (jtv)
milestone: none → 10.12
tags: added: qa-needstesting
Changed in rosetta:
status: Triaged → Fix Committed
Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote :

Deployed to nodowntime, dunno if thats enough for you to move on the next bug or not.

Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.