Branch.addLandingTarget adds a review even when the caller requests there be none.
Bug #671458 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
If calling code wants to use the default reviewer, it should not supply reviewers, or specify it as None.
If the calling code specifies an empty list, addLandingTarget should honour this and not add reviewers.
Resubmit uses addLandingTarget, and resubmit attempts to perfectly copy the list of reviewers. This is not currently possible, because if the superseded proposal has an empty reviewer list, the default reviewer will be added to the new proposal.
To post a comment you must log in.
