code review should show changes since initial proposal
Bug #670936 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Aaron Bentley | ||
Bug Description
When the source branch is modified, this should be reflected not just by updating the overall diff, but by showing the changes as a diff.
Related branches
lp:~abentley/launchpad/incremental-diff-job
- Graham Binns (community): Approve (code)
-
Diff: 673 lines (+301/-66)9 files modifiedlib/lp/code/configure.zcml (+5/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+20/-0)
lib/lp/code/model/branch.py (+12/-4)
lib/lp/code/model/branchmergeproposal.py (+11/-0)
lib/lp/code/model/branchmergeproposaljob.py (+93/-14)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+69/-3)
lib/lp/code/model/tests/test_diff.py (+45/-44)
lib/lp/code/scripts/tests/test_merge_proposal_jobs.py (+12/-1)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+34/-0)
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.11 |
| tags: | added: qa-untestable |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r9950 (http://