Make it easy to select branch owner as recipe owner when creating recipe
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
High
|
Aaron Bentley | ||
Bug Description
When I create a recipe, there are two natural choices as to who should own it:
1. Me
2. The owner of the branch I'm basing the recipe on
All of the other teams I'm in are very unlikely to actually be relevant. The UI for selecting recipe owner should make it easy to select either myself or the owner of the branch I'm basing the recipe on, perhaps in a way similar to selecting the target branch of a merge proposal.
Related branches
- Gavin Panella (community): Approve on 2010-11-11
- Curtis Hovey (community): Approve (ui) on 2010-11-11
- Guilherme Salgado (community): Approve (ui*) on 2010-11-10
-
Diff: 477 lines (+205/-108)4 files modifiedlib/canonical/widgets/suggestion.py (+169/-103)
lib/lp/code/browser/branch.py (+1/-1)
lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+33/-3)
| Aaron Bentley (abentley) wrote : | #1 |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| status: | Triaged → In Progress |
| Jonathan Lange (jml) wrote : Re: [Bug 670431] Re: Make it easy to select branch owner as recipe owner when creating recipe | #2 |
On Thu, Nov 4, 2010 at 7:04 PM, Aaron Bentley <email address hidden> wrote:
> I assume you don't want people to be able to select the owner if they
> are not a member of the owner?
Right.
| Aaron Bentley (abentley) wrote : | #3 |
If we're going to give suggestions, I wonder if branch.owner goes far enough? Won't some projects have packaging teams? Perhaps we should show members of branch.target.owner that have PPAs? Or what about owners of existing recipes for branch.target?
| Aaron Bentley (abentley) wrote : | #4 |
And should we omit the suggestions from the general list?
Fixed in stable r11948 <http://
| Changed in launchpad-code: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
I assume you don't want people to be able to select the owner if they are not a member of the owner?