ec2 land and bzr lp-land should recognize "unreviewed" review types

[Gavin Panella]

The "Activities" section in:

  https://dev.launchpad.net/PolicyAndProcess/OptionalReviews

instructs us to self-review by approving merge proposals with the
"unreviewed" type. However, ec2 land does not count these type of
reviews. Upon inspection, neither does bzr lp-land.

For now it is sufficient to self review without a type (agreed with
jml and lifeless). For stats, it is still possible to determine
that a proposal is self-reviewed.

[Gavin Panella (allenap)]

Just to be sure, I checked and it's easy to see if a merge proposal is
self-reviewed:

    >>> from launchpadlib import launchpad
    >>> root = launchpad.Launchpad.login_with(...)
    >>> branch = root.branches.getByUrl(url='...')
    >>> merge_proposal = branch.landing_targets[0]
    >>> votes = merge_proposal.votes[:2]
    >>> self_reviewed = (
    ... len(votes) == 1 and votes[0].reviewer == branch.owner)

[Gary Poster (gary)]

Thank you for verifying that it is easy to see if a merge proposal is self-reviewed. Because of this, I'm going to mark this as Won't Fix. It's extra work for us, and AFAICT extra unnecessary for people landing branches.

[Gavin Panella (allenap)]

I've updated https://dev.launchpad.net/PolicyAndProcess/OptionalReviews.

[Gary Poster (gary)]

Thanks again, Gavin.

Gary

[Robert Collins (lifeless)]

Hmm, this isn't actually 'easy' - landing_candidates is the collection to use but it filters MERGED objects. So we're going to need to extend the API to be able to do this in an automated fashion.

[Gavin Panella (allenap)]

Oops, I wrote this from the perspective of a source branch without
thinking about how to find out the source branches. I think all merged
proposals can be obtained from the target branch with:

  branch.getMergeProposals(status=u"Merged")

(status can also be a list of interesting statsues.)

[Robert Collins (lifeless)]

On Mon, Nov 8, 2010 at 10:40 AM, Gavin Panella
<email address hidden> wrote:
> Oops, I wrote this from the perspective of a source branch without
> thinking about how to find out the source branches. I think all merged
> proposals can be obtained from the target branch with:
>
>  branch.getMergeProposals(status=u"Merged")

This list is thousands long for LP though :)

I haven't [yet] looked to see if there is a date filter, but if there
is it should be relatively easy.

-Rob