findSimilarBugs() returns bug task you are using

[Brian Murray]

Occasionally, when using findSimilarBugs with bug tasks you are returned the bug task for the bug report you were initially querying from.

For example:

In [6]: bug = launchpad.bugs[428017]
In [7]: [bug.id for bug in bug.bug_tasks[0].findSimilarBugs()]
Out[7]: [428017]

This doesn't seem terribly useful to me.

[Brian Murray (brian-murray)]

351626 is another example of this.

[Brian Murray (brian-murray)]

I think this occurs because the exact same bug task is excluded but we are returning bugs and not bug tasks, so if you have a bug with multiple tasks one of the additional tasks will be returned.

From lib/lp/bugs/model/bugtask.py:

        matching_bugtasks = [
            bug_task for bug_task in matching_bugtasks[:4*limit]
            if bug_task != self]

        matching_bugs = getUtility(IBugSet).getDistinctBugsForBugTasks(
            matching_bugtasks, user, limit)
        return matching_bugs

So 'if bug_task.bug.id != self.bug.id' would likely resolve this.

[Launchpad QA Bot (lpqabot)]

Fixed in db-stable r9948 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9948>.