The buildd-manager should use non-blocking I/O when getting files from the slave
Bug #662631 reported by
Julian Edwards
on 2010-10-18
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
Medium
|
Julian Edwards | ||
Bug Description
The slave has a getFile method that uses urllib, we can change this to use Twisted's getPage which is asynchronous. That means many other places in the code will need to be updated to cope with this. See the XXXes in the code referring to this bug.
Related branches
lp:~julian-edwards/launchpad/async-file-uploads-bug-662631
- Graham Binns (community): Approve (code) on 2010-11-16
- Jonathan Lange (community): Abstain on 2010-11-16
-
Diff: 1093 lines (+412/-233)16 files modifiedlib/lp/buildmaster/interfaces/builder.py (+1/-1)
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+3/-0)
lib/lp/buildmaster/interfaces/packagebuild.py (+6/-1)
lib/lp/buildmaster/model/builder.py (+63/-37)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+2/-3)
lib/lp/buildmaster/model/packagebuild.py (+107/-84)
lib/lp/buildmaster/tests/mock_slaves.py (+20/-11)
lib/lp/buildmaster/tests/test_builder.py (+45/-1)
lib/lp/buildmaster/tests/test_packagebuild.py (+35/-28)
lib/lp/code/model/sourcepackagerecipebuild.py (+6/-4)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+3/-1)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+3/-1)
lib/lp/soyuz/tests/test_binarypackagebuildbehavior.py (+40/-31)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+47/-19)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+26/-10)
lib/lp_sitecustomize.py (+5/-1)
Julian Edwards (julian-edwards)
on 2010-10-18
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: buildd-manager |
Julian Edwards (julian-edwards)
on 2010-11-10
| Changed in soyuz: | |
| assignee: | nobody → Julian Edwards (julian-edwards) |
Julian Edwards (julian-edwards)
on 2010-11-10
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Jonathan Lange (jml)
on 2010-11-30
| tags: | added: buildd-scalability |
| Changed in soyuz: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
Julian Edwards (julian-edwards)
on 2010-12-01
| tags: |
added: qa-ok removed: qa-needstesting |
| Launchpad QA Bot (lpqabot) wrote : | #2 |
Fixed in stable r12014 (http://
| tags: |
added: qa-untestable removed: qa-ok |
Julian Edwards (julian-edwards)
on 2010-12-03
| tags: |
added: qa-ok removed: qa-untestable |
Curtis Hovey (sinzui)
on 2010-12-08
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r10021 <http://