CodeImportResultPruner deletes too much
Bug #662393 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
The sql query to determine which code import results to delete is overly eager.
The subselect has a limit which is fine if there is only one code import being checked. However if there are multiple code imports being checked, only a subset of the results that should be kept are being kept.
Revision history for this message
| Tim Penhey (thumper) wrote Re: [Bug 662393] [NEW] CodeImportResultPruner deletes too much | #1 |
| Changed in launchpad: | |
| importance: | Medium → High |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| Changed in launchpad: | |
| importance: | High → Low |
To post a comment you must log in.
Just thinking that perhaps the SQL is right, but we should be keeping more.
Right now we are saving just the consecutive failure count, whereas we should
be saving the number of rows that we show on the page.