Message-ID: <4CB8446C.8010903@canonical.com> Date: Fri, 15 Oct 2010 14:09:16 +0200 From: Zygmunt Krynicki Organization: Canonical User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100922 Thunderbird/3.1.4 MIME-Version: 1.0 To: mp+38511@code.launchpad.net Subject: Re: [Merge] lp:~zkrynicki/launch-control/better_databrowse_app into lp:launch-control References: <20101015120140.22069.76368.codereview@gandwana.canonical.com> In-Reply-To: <20101015120140.22069.76368.codereview@gandwana.canonical.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 W dniu 15.10.2010 14:01, James Westby pisze: > Review: Needs Information > Hi, > > I don't like this approach. > > Firstly there is no test that verifies the fix is working. Properly testing this would require us adding a project-specific test where we look at the HTML output. The only thing you can test for is that context processors are being used when rendering certain views. I'd say that for a temporary solution this fix is sufficient. I could have simply copied 100% of the sources and patch the missing RequestContext, that would work as well. Would you prefer to see that solution? > Also, hacking a copy of the app in to the tree isn't something > that we should be doing. It's a bugfix for a problem that is in django contrib application. Would you prefer to fix django and wait forever to get this accepted upstream and released? I don't. > Given that databrowse is a temporary UI, is the impact particularly > high? Will the user be able to view private streams if we don't do this? Databrowse allows to access any data. The best we can hope to achieve is to limit this to authenticated users. > Is this something that should be fixed in databrowse for everyone? This should be put for discussion with django upstream. I suppose it's a design bug and nothing more but having read some discussions over equally "obvious" things where upstreams were disagreeing with the reporters for years I cannot be certain. Thanks ZK -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJMuERsAAoJEKkR4hQBRI+l+u8IAMTICscXGX4jGAUO9SILtog0 bqRWx63e6bEd5fCEwRxSOqOIiDJj6sQNl7pPXgyoaIdM/ehPB6SLSG2lbRxZYfKU cepPmMNcnB7urdeqSorNgBc4KD6pIUKpqaN5ZLg4+zEYNBgOF3fkRBUnFWOPtNHX BnCxsH3xIsNHGt4iNwbsZiD2FtDIiiUQmjkILyLErv9Iai+Q8uuJLcqnOdR/wcjQ /65SUZUI446e4lVSWQTNralKIgUeQynutoLB7xWz5JOJRcp6bZbqumD4KiVjfqYs ONMOYBAetjiydj/2P+NfVu59MmEkcmHu+h3hVlzle+TWm6JZrMvOtGzSb5/I//o= =UTGc -----END PGP SIGNATURE-----