Launchpad itself

Source domination is inefficient

Bug #654372 reported by William Grant on 2010-10-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
High
William Grant
Launchpad itself 10.12
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Dominator.judgeAndDominate's source domination regularly takes 2.5 minutes per series to collect candidates (mostly issuing queries in _sortPackages). It can be easily optimised the same way as binary domination: create a temporary table of candidate names first. This should make it sub-second.

Related branches

lp:~wgrant/launchpad/bug-654372-optimise-domination
Graham Binns (community): Approve (code) on 2010-11-16
Diff: 143 lines (+59/-47)
1 file modified
lib/lp/archivepublisher/domination.py (+59/-47)
Julian Edwards (julian-edwards) on 2010-10-04
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
tags: added: soyuz-publisher tech-debt
Jonathan Lange (jml) on 2010-10-11
tags: added: new-release-cycle-process
William Grant (wgrant) on 2010-11-15
Changed in soyuz:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11931 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11931>.

Changed in soyuz:
milestone: none → 10.12
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
Julian Edwards (julian-edwards) on 2010-11-22
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless) wrote :

What machine does this need to be deployed to? We've deployed to nodowntime (including cesium).

Julian Edwards (julian-edwards) wrote : Re: [Bug 654372] Re: Source domination is inefficient

On Tuesday 23 November 2010 04:51:56 you wrote:
> What machine does this need to be deployed to? We've deployed to
> nodowntime (including cesium).

cocoplum/germanium

Curtis Hovey (sinzui) on 2010-12-08
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers