Launchpad itself

Default Recipe text should contain {debupstream}

Bug #652109 reported by B. Clausius on 2010-09-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
Medium
Tim Penhey
Launchpad itself 10.12
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Im creating a recipe on edge.launchpad and get this recipe text:
# bzr-builder format 0.2 deb-version 0+{revno}
lp:gedit-bzr-panel

I think the suggested text should contain {debupstream}, e.g.
# bzr-builder format 0.2 deb-version {debupstream}+bzr{revno}
lp:gedit-bzr-panel

Related branches

lp:~thumper/launchpad/recipe-default-version
Tim Penhey (community): Approve on 2010-11-24
Diff: 169 lines (+21/-19)
4 files modified
lib/canonical/buildd/test_buildd_recipe (+1/-1)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+13/-13)
lib/lp/code/interfaces/sourcepackagerecipe.py (+1/-1)
lib/lp/code/model/tests/test_recipebuilder.py (+6/-4)
Aaron Bentley (abentley) wrote : Re: [Bug 652109] [NEW] Default Recipe text should contain {debupstream}

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/30/2010 10:55 AM, B Clausius wrote:
> I think the suggested text should contain {debupstream}, e.g.
> # bzr-builder format 0.2 deb-version {debupstream}+bzr{revno}
> lp:gedit-bzr-panel

It is hard to recover from using a version number that is too high, so
we felt that the safest default version number was 0. Defaulting to
{debupstream} could introduce problems if the packaging is from a newer
version than the source code.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyl8yQACgkQ0F+nu1YWqI1hSwCffAIbSCQ0lw7KCBCFJHGrJxaW
3q8An3rUc3on4pEBw40YBNUA6R8uFtEz
=gaNQ
-----END PGP SIGNATURE-----

Tim Penhey (thumper) wrote :

I'm not convinced that either approach is best right now. I guess we could always ask James.

Changed in launchpad-code:
assignee: nobody → James Westby (james-w)
status: New → Incomplete
Tim Penhey (thumper) wrote :

James suggested: {debupstream}-0~{revno}

Changed in launchpad-code:
status: Incomplete → Triaged
importance: Undecided → Medium
assignee: James Westby (james-w) → Tim Penhey (thumper)
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11966 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11966>.

Changed in launchpad-code:
milestone: none → 10.12
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper) on 2010-11-24
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless) on 2010-11-26
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers