Launchpad itself

generate-ppa-htaccess takes too long to update passwords

Bug #651827 reported by Michael Nelson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

bug 628711 improved the actual execution time of the generate-ppa-htaccess script from over two minutes to under a second, but the script still takes 25 seconds of setup/tear down each time it runs.

Turning the cronscript into a daemon/upstart service will alleviate the issue (and allow us to update the passwords more frequently too).

Related branches

~cjwatson/launchpad:wsgi-ppa-auth
Thiago F. Pappacena (community): Approve
Diff: 968 lines (+676/-23)
20 files modified
Makefile (+1/-0)
configs/development/local-launchpad-apache (+29/-2)
lib/lp/services/config/schema-lazr.conf (+5/-0)
lib/lp/soyuz/doc/archiveauthtoken.txt (+24/-1)
lib/lp/soyuz/interfaces/archiveapi.py (+46/-0)
lib/lp/soyuz/interfaces/archiveauthtoken.py (+18/-7)
lib/lp/soyuz/model/archiveauthtoken.py (+29/-7)
lib/lp/soyuz/wsgi/__init__.py (+0/-0)
lib/lp/soyuz/wsgi/archiveauth.py (+78/-0)
lib/lp/soyuz/wsgi/tests/__init__.py (+0/-0)
lib/lp/soyuz/wsgi/tests/test_archiveauth.py (+149/-0)
lib/lp/soyuz/xmlrpc/archive.py (+62/-0)
lib/lp/soyuz/xmlrpc/tests/__init__.py (+0/-0)
lib/lp/soyuz/xmlrpc/tests/test_archive.py (+124/-0)
lib/lp/systemhomes.py (+8/-1)
lib/lp/xmlrpc/application.py (+8/-2)
lib/lp/xmlrpc/configure.zcml (+14/-1)
lib/lp/xmlrpc/interfaces.py (+3/-1)
scripts/wsgi-archive-auth.py (+71/-0)
utilities/rocketfuel-setup (+7/-1)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

This basically means converting the existing script to be a twistd process that uses callLater() - should be trivial.

tags: added: p3a ppa
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
tags: added: software-center
Robert Collins (lifeless)
summary: - generate-ppa-htaccess setup/teardown takes too long
+ generate-ppa-htaccess takes too long to update passwords
Revision history for this message
Colin Watson (cjwatson) wrote :

We now check passwords in real time using a WSGI authenticator. generate-ppa-htaccess is currently still needed for some bookkeeping tasks such as sending email about expiry, but those are less time-sensitive.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.