Launchpad itself

Architecture-independent population logic is duplicated

Bug #649859 reported by Julian Edwards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant
Launchpad itself 11.02

Bug Description

IPublishingSet.copyBinariesTo() and IPackageUploadBuild.publish() both contain the same logic for populating arch-indep binaries in a distroarchseries.

The logic needs to be refactored.

See original description

Related branches

lp:~wgrant/launchpad/bug-629835-copier-architectures
Julian Edwards (community): Approve (code)
Diff: 481 lines (+217/-124)
6 files modified
lib/lp/soyuz/interfaces/publishing.py (+23/-0)
lib/lp/soyuz/model/publishing.py (+56/-47)
lib/lp/soyuz/model/queue.py (+11/-41)
lib/lp/soyuz/scripts/packagecopier.py (+9/-1)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+116/-34)
lib/lp/soyuz/tests/test_publishing.py (+2/-1)
Julian Edwards (julian-edwards)
tags: added: easy
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
William Grant (wgrant)
description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12220 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12220>.

Changed in launchpad:
milestone: none → 11.02
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.