Updating sourcecode directory when it is a no-op is unnecessarily slow
Bug #643715 reported by
Gary Poster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Invalid
|
Undecided
|
Gary Poster | ||
Bug Description
When a local tree exists for one of the branches in the sourcecode directory, you can quickly and easily find what the revno of the tree is. That's what bzr revno does. Instead, we always open the remote branch, which is unnecessarily slow when the current revno and the desired revno match.
Related branches
lp:~gary/launchpad/bug643715
- Aaron Bentley (community): Needs Fixing
- Jonathan Lange (community): Approve
-
Diff: 96 lines (+28/-9)1 file modifiedlib/devscripts/sourcecode.py (+28/-9)
Revision history for this message
| Gary Poster (gary) wrote | #1 |
Revision history for this message
| Gary Poster (gary) wrote | #2 |
| Changed in launchpad-foundations: | |
| importance: | Low → Undecided |
| status: | Triaged → Invalid |
To post a comment you must log in.
Unfortunately abentley says this is not safe:
abentley: gary_poster, your patch is treating revnos as if they were revision-ids. It will fail to do an update if the definition of the revno has changed.
gary_poster: abentley: agreed, but when would that happen for this use case
abentley: gary_poster, if someone uncommits a revision.
gary_poster: ew, didn't know you could do that with a public branch but I guess that makes sense within the model
gary_poster: ok, that's a shame, but if that's a reasonable concern then we should just drop it. thanks for the look abentley