dkim-signed mail to new@bugs doesn't work

Bug #643219 reported by Martin Pool on 2010-09-20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Martin Pool

Bug Description

Continuing from bug 316272: dkim-authenticated mail to change the state of an existing bug works, but mail to new@bugs is rejected.

The problem seems to be that MaloneHandler.process redundantly checks the mail has gpg signature, rather than trusting the earlier code that checks whether or not it's authenticated.

Related branches

Martin Pool (mbp) wrote :

Now I think fixed in lp:~mbp/launchpad/dkim, but needs a test.

Jonathan Lange (jml) on 2010-11-25
tags: added: dkim
Jonathan Lange (jml) on 2010-12-01
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in launchpad-foundations:
milestone: none → 10.12
tags: added: qa-needstesting
Martin Pool (mbp) wrote :

I testing this on staging as follows:

* mail without a valid dkim signature is rejected as previously
* mail with a valid dkim signature to new creates a new bug <>
* mail with a valid GPG signature is still accepted <>

Martin Pool (mbp) wrote :

Also tested that mail with no signature that only adds a comment is still accepted. So I think this is all safely working with no regressions.

Martin Pool (mbp) on 2010-12-06
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui) on 2010-12-08
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers