Complete b0rkage of oops timing info
Bug #630612 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Robert Collins | ||
Bug Description
The timing information for oopses is very obviously broken: it reports negative query times, and the SQL-vs-non-SQL times are completely out of whack.
Triaging note: this currently affects edge oopses but not production oopses. So it's in the reporting of the oopses, not in the oops tools. Robert's been overhauling the oops logging so it's not impossible to see some teething problems.
Related branches
lp:~lifeless/launchpad/oops
- Michael Hudson-Doyle: Approve
-
Diff: 43 lines (+13/-2)2 files modifiedlib/canonical/launchpad/webapp/adapter.py (+10/-2)
lib/lp/services/timeline/timedaction.py (+3/-0)
- Jeroen T. Vermeulen (community): Approve (code)
- Tim Penhey (community): Approve (release-critical)
- Graham Binns: Pending (release-critical) requested
-
Diff: 407 lines (+127/-31)11 files modifiedlib/canonical/launchpad/doc/librarian.txt (+19/-0)
lib/canonical/launchpad/webapp/errorlog.py (+5/-1)
lib/canonical/librarian/client.py (+26/-7)
lib/canonical/librarian/ftests/test_client.py (+3/-2)
lib/lp/services/mail/sendmail.py (+20/-6)
lib/lp/services/mail/tests/test_sendmail.py (+0/-4)
lib/lp/services/memcache/client.py (+26/-1)
lib/lp/services/memcache/tests/test_memcache_client.py (+19/-6)
lib/lp/services/timeline/tests/test_timedaction.py (+4/-2)
lib/lp/services/timeline/timedaction.py (+1/-1)
lib/lp/testing/tests/test_testcase.py (+4/-1)
| affects: | oops-tools → launchpad |
| summary: |
- Complete b0rkage of timing info + Complete b0rkage of oops timing info |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
Revision history for this message
| Robert Collins (lifeless) wrote | #3 |
Revision history for this message
| Robert Collins (lifeless) wrote | #4 |
Revision history for this message
| Robert Collins (lifeless) wrote | #5 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #6 |
| Changed in launchpad: | |
| assignee: | nobody → Robert Collins (lifeless) |
| milestone: | none → 10.09 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | New → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #7 |
| affects: | launchpad → launchpad-foundations |
| Changed in launchpad-foundations: | |
| milestone: | 10.09 → none |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #8 |
| Changed in launchpad-foundations: | |
| milestone: | none → 10.09 |
| tags: |
added: qa-needstesting removed: qa-untestable |
| Changed in launchpad-foundations: | |
| importance: | Undecided → Critical |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #9 |
| Changed in launchpad-foundations: | |
| milestone: | 10.09 → 10.10 |
| tags: |
added: qa-needstesting removed: qa-ok |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #11 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #12 |
| tags: |
added: qa-untestable removed: qa-needstesting |
To post a comment you must log in.
please list some example borked oopses, thanks.