Avoid removeSecurityProxy calls in browser/logintoken.py

Bug #62674 reported by Guilherme Salgado
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

In that file we have to remove the security proxy of a person object in three different places, because we have a scenario where the user is not logged in but we need to set some attributes that require the launchpad.Edit permission. Since at these points we know the user interacting with the system has access to the email address registered for the account in context, we could avoid removing the security proxy by logging in the user and then setting the attributes.

Revision history for this message
Guilherme Salgado (salgado) wrote :

I've tried this by calling the BaseLoginTokenView.logInPersonByEmail() method, but it didn't work.

As Bjorn pointed out, this might be because that method doesn't replace the current anonymous interaction with a new authenticated one.

Changed in launchpad:
importance: Undecided → Low
status: Unconfirmed → Confirmed
Curtis Hovey (sinzui)
tags: added: tech-debt
Curtis Hovey (sinzui)
security vulnerability: yes → no
visibility: private → public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.