merge request review request of a team should indicate such

Bug #619954 reported by Monty Taylor on 2010-08-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Unassigned

Bug Description

When someone requests that a team review a merge request, the emails sent out are addressed to each individual rather than to the team. This can have the effect of misleading someone into thinking that they were explicitly requested to personally review the merge request. If they are operating solely over email, they are missing that the request as simply for any member of the team to do the review.

It would be stellar if the email could indicate that the request was made of the team, so that the reviewer knows what his status is related to the merge request just by reading the notification email.

Monty Taylor (mordred) on 2010-08-18
tags: added: openstack
affects: launchpad → launchpad-code
Aaron Bentley (abentley) wrote :

Don't we already do that? We say "Your team bzr-core is requested to review the proposed merge of lp:~bialix/bzr/deprecate into lp:bzr." or "You are requested to review the proposed merge of lp:~jelmer/bzr/merge-dir-prober into lp:bzr."

Changed in launchpad-code:
status: New → Incomplete
importance: Undecided → Medium
tags: added: code-review
Monty Taylor (mordred) wrote :

On 08/18 I got this message:

You have been requested to review the proposed merge of lp:~ewanmellor/nova/xenapi-concurrency-model into lp:nova.

Related to this merge request:

https://code.edge.launchpad.net/~ewanmellor/nova/xenapi-concurrency-model/+merge/32939

You will note that I am not on the list of people who were personally asked to review the merge request. The email was sent directly to my personal address and not to a mailing list, and I got this header:

X-Launchpad-Message-Rationale: Reviewer @nova

Changed in launchpad-code:
status: Incomplete → New
Aaron Bentley (abentley) on 2010-08-25
Changed in launchpad-code:
status: New → Triaged
Curtis Hovey (sinzui) on 2011-10-02
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers