Launchpad itself

Add data.tar.xz support

Bug #619152 reported by Colin Watson
34
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Colin Watson

Bug Description

dpkg 1.15.6 added support for data.tar.xz members of .deb packages. Launchpad should support uploads using this.

Related branches

lp:~cjwatson/launchpad/dpkg-xz-support-619152
Jelmer Vernooij (community): Approve (code)
Launchpad code reviewers: Pending requested
Diff: 259 lines (+195/-5)
5 files modified
lib/lp/archiveuploader/nascentuploadfile.py (+47/-3)
lib/lp/archiveuploader/tests/data/suite/bar_1.0-1_xz/bar_1.0-1.dsc (+28/-0)
lib/lp/archiveuploader/tests/data/suite/bar_1.0-1_xz/bar_1.0-1_source.changes (+40/-0)
lib/lp/archiveuploader/tests/data/suite/bar_1.0-1_xz_binary/bar_1.0-1_i386.changes (+34/-0)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+46/-2)
Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → Low
tags: added: soyuz-upload
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Jelmer, can you see how much work this is to fix please? If it's not much we might consider doing it as part of your upcoming changes to the upload processor.

Revision history for this message
Colin Watson (cjwatson) wrote :

I pushed up a branch for this as lp:~cjwatson/launchpad/dpkg-xz-support-619152; would welcome a review.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Somebody PLEASE review the branch. It's a really basic and needed feature and the fix is awaiting review for 8 months already!

Revision history for this message
Colin Watson (cjwatson) wrote :

We're on the home stretch now. Details are in the merge proposal.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13786 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13786>.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

Works fine on DF.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Oibaf (oibaf) wrote :

It isn't working here:
https://launchpad.net/~oibaf/+archive/test/+build/2746453

I changed lzma to xz and also added:
Pre-Depends: dpkg (>= 1.15.6)

to every binary section of my package.

Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 619152] Re: Add data.tar.xz support

On Fri, Aug 26, 2011 at 10:05:20AM -0000, Oibaf wrote:
> I changed lzma to xz and also added:
> Pre-Depends: dpkg (>= 1.15.6)

Actually, you added Pre-Depends: dpkg-dev (>= 1.15.6). Make that dpkg
rather than dpkg-dev.

Revision history for this message
Oibaf (oibaf) wrote :

It works indeed, sorry for the noise.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.