non-ascii characters in tag name cause traceback

[Jelmer Vernooij]

  affects launchpad-code

  affects bzr-git
  status triaged

Importing libgee, which has a tag with non-ascii characters in its name
causes a traceback:

gwenhwyvar:~/lp/lib/canonical/buildd% BZR_PDB=1 bzr.dev branch
git://git.gnome.org/libgee ~/tmp/libgee
bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode
byte 0xc2 in position 11: ordinal not in
range(128)

Traceback (most recent call last):
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/commands.py", line 911, in
exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/commands.py", line 1111, in
run_bzr
    ret = run(*run_argv)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/commands.py", line 689, in
run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/commands.py", line 704, in
run
    return self._operation.run_simple(*args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/cleanup.py", line 135, in
run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/cleanup.py", line 165, in
_do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/builtins.py", line 1213, in
run
    source_branch=br_from)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/bzrdir.py", line 1268, in
sprout
    revision_id=revision_id, repository_policy=repository_policy)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/decorators.py", line 140, in
read_locked
    result = unbound(self, *args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/branch.py", line 1275, in
sprout
    self.copy_content_into(result, revision_id=revision_id)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/branch.py", line 1313, in
copy_content_into
    revision_id=revision_id)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/decorators.py", line 194, in
write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/branch.py", line 3362, in
copy_content_into
    self.source.tags.merge_to(self.target.tags)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/tag.py", line 212, in
merge_to
    to_tags._set_tag_dict(result)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/tag.py", line 158, in
_set_tag_dict
    return
self.branch._set_tags_bytes(self._serialize_tag_dict(new_dict))
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/tag.py", line 162, in
_serialize_tag_dict
    for k,v in tag_dict.items())
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/tag.py", line 162, in
<genexpr>
    for k,v in tag_dict.items())
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 11:
ordinal not in range(128)

This breaks lp:~vcs-imports/libgee/trunk

[Jelmer Vernooij (jelmer)]

  affects bzr-git
  status fixcommitted

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11386 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11386>.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11474 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11474>.