| 2010-08-06 09:33:25 |
Julian Edwards |
bug |
|
|
added bug |
| 2010-08-06 09:33:43 |
Julian Edwards |
bug |
|
|
added subscriber Henning Eggers |
| 2010-08-06 09:33:47 |
Julian Edwards |
tags |
|
tech-debt |
|
| 2010-08-06 09:33:51 |
Julian Edwards |
soyuz: status |
New |
Triaged |
|
| 2010-08-06 09:33:55 |
Julian Edwards |
soyuz: importance |
Undecided |
High |
|
| 2010-08-06 09:34:19 |
Julian Edwards |
bug task added |
|
launchpad-foundations |
|
| 2010-08-06 09:37:51 |
Julian Edwards |
description |
RotatableFileLogeObserver is currently only tested in the buildd-manager tests in lib/lp/buildmaster. This is wrong for 2 reasons:
1. it relies on the behaviour of the buildd-manager
2. it's slow, because it waits several seconds for a logging event in the buildd-manager code
The tests should live in the lp.services.twistedsupport test code and use Deferreds or task.Clock() to avoid a long wait in the test. I have also disabled the tests in the buildd-manager test file because it's preventing me from landing a change that reduces the logging. |
RotatableFileLogObserver is currently only tested in the buildd-manager tests in lib/lp/buildmaster. This is wrong for 2 reasons:
1. it relies on the behaviour of the buildd-manager
2. it's slow, because it waits several seconds for a logging event in the buildd-manager code
The tests should live in the lp.services.twistedsupport test code and use Deferreds or task.Clock() to avoid a long wait in the test. I have also disabled the tests in the buildd-manager test file because it's preventing me from landing a change that reduces the logging.
|
|
| 2010-08-06 09:37:58 |
Julian Edwards |
summary |
RotatableLogFileObserver is tested in the wrong place |
RotatableFileLogObserver is tested in the wrong place |
|
| 2010-08-06 21:02:57 |
Gary Poster |
launchpad-foundations: status |
New |
Triaged |
|
| 2010-08-06 21:03:08 |
Gary Poster |
launchpad-foundations: importance |
Undecided |
Low |
|
| 2012-01-05 03:15:16 |
Robert Collins |
summary |
RotatableFileLogObserver is tested in the wrong place |
RotatableFileLogObserver is in the LP tree rather than in a reusable location |
|
