Content-Type: multipart/mixed; boundary="===============9080829649142473035=="
MIME-Version: 1.0
To: Mathias Gug <mathiaz@ubuntu.com>
From: noreply@bugs.launchpad.net
Subject: Submit Request Failure
Message-Id: <20100730030042.16835.11999.launchpad@loganberry.canonical.com>
Date: Fri, 30 Jul 2010 03:00:42 -0000
Reply-To: noreply@bugs.launchpad.net
Sender: bounces@canonical.com
Errors-To: bounces@canonical.com
Precedence: bulk

--===============9080829649142473035==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

An error occurred while processing a mail you sent to Launchpad's email
interface.


Error message:

Signature couldn't be verified: (7, 8, u'Bad signature')

-- =

For more information about using Launchpad by e-mail, see
https://help.launchpad.net/EmailInterface
or send an email to help@launchpad.net
--===============9080829649142473035==
Content-Type: message/rfc822
MIME-Version: 1.0

Return-Path: <mathiaz@ubuntu.com>
X-Original-To: launchpad@mail.canonical.com
Delivered-To: launchpad@mail.canonical.com
Received: from fiordland.canonical.com (fiordland.canonical.com
	[91.189.94.145])
	by grenadilla.canonical.com (Postfix) with ESMTP id 1E44B131E3CF
	for <launchpad@mail.canonical.com>;
	Fri, 30 Jul 2010 03:59:35 +0100 (BST)
Received: from adelie.canonical.com (userdb.internal [91.189.90.139])
	by fiordland.canonical.com (Postfix) with ESMTP id 1B018A185DF
	for <mp+31303@code.launchpad.net>; Fri, 30 Jul 2010 03:59:35 +0100 (BST)
Received: from hutte.canonical.com ([91.189.90.181])
	by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian))
	id 1Oefot-0001OQ-1a
	for <mp+31303@code.launchpad.net>; Fri, 30 Jul 2010 03:59:35 +0100
Received: from dsl-173-206-147-0.tor.primus.ca ([173.206.147.0]
	helo=mathiaz-tp.localdomain) by hutte.canonical.com with esmtpsa
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69)
	(envelope-from <mathiaz@ubuntu.com>) id 1Oefos-0003AE-Q5
	for mp+31303@code.launchpad.net; Fri, 30 Jul 2010 03:59:35 +0100
Received: by mathiaz-tp.localdomain (Postfix, from userid 1000)
	id 210EA1A1551; Thu, 29 Jul 2010 22:59:33 -0400 (EDT)
Subject: Re: [Merge] lp:~clint-fewbar/review-new-branches/ceph-new-pkg into
	lp:review-new-branches
From: Mathias Gug <mathiaz@ubuntu.com>
To: mp+31303 <mp+31303@code.launchpad.net>
In-reply-to: <20100729154755.18112.6660.launchpad@loganberry.canonical.com>
References: <20100729154755.18112.6660.launchpad@loganberry.canonical.com>
Date: Thu, 29 Jul 2010 22:59:29 -0400
Message-Id: <1280454736-sup-8529@mathiaz-tp.mathiaz.net>
User-Agent: Sup/0.10.2
Content-Type: multipart/signed; micalg="pgp-sha1";
	boundary="=-1280458773-114419-2530-1078-2-=";
	protocol="application/pgp-signature"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


--=-1280458773-114419-2530-1078-2-=
Content-Type: text/plain; charset=utf8

* debian/changelog

  The file should be trimmed to only have one entry mentioning the
  initial packaging for Ubuntu and refering the need-packaging bug in LP
  (bug 607730):

    ceph (0.21-0ubuntu1) maverick; urgency=low

      * Initial release based on upstream package (LP: #607730).

* debian/control

  The maintainer field should be updated per
  https://wiki.ubuntu.com/DebianMaintainerField.

* debian/copyright

  I would recommend to format the content of this file according to
  the 'Machine-readable debian/copyright' DEP - see
  http://dep.debian.net/deps/dep5/.

  The Files: * section has an empty line on line 14.

  src/include/ceph_hash.cc: should also be mentioned as it's copyrighted
  under Public Domain.

  src/os/btrfs_ioctl.h: is under GPLv2.

  Running 'licensecheck -r .' in the top source directory will output a
  good estimate of the license and copyright for each file.

* debian/rules: I'd recommend to properly support autotools in the build
  system. See /usr/share/doc/autotools-dev/README.Debian.gz available
  from the autotools-dev package.

* Log files should be properly handled as outlined in the Debian Policy
  Section 10.8 [1]
  
  [1]: http://www.debian.org/doc/debian-policy/ch-files.html#s10.8

  Log directory should be deleted on package purge.

* Configuration files in /etc/ seem to be sample files given their name
  in ceph.install:

    etc/ceph/sample.ceph.conf
    etc/ceph/sample.fetch_config

  Are these files providing a default working configuration? If so their
  name should not start with sample. If not they should be shipped under
  /usr/share/doc/ceph/ and a default working configuration should be
  shipped as part of the package.

* AFAICT all commands to create a filesystem are located in /sbin/.
  mkcephfs should probably be there as well instead of
  usr/sbin/.

* debian/rados.install is not needed as there isn't any rados package defined
  in debian/control.

* Upon installation of the ceph package it seems that there isn't a
  default working configuration. Is it possible to provide a default
  working configuration?

 review needs-fixing 

-- 
Mathias Gug
Ubuntu Developer  http://www.ubuntu.com

--=-1280458773-114419-2530-1078-2-=
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxSQBEACgkQM0thG+z3pViyggCfSU2nQ8K67VJZrtyZu+INfCEK
g2oAn0rgdaP3jMM1BrMMyppCOMRX7WcL
=gFFh
-----END PGP SIGNATURE-----

--=-1280458773-114419-2530-1078-2-=--

--===============9080829649142473035==--