Activity log for bug #612351

Date Who What changed Old value New value Message
2010-08-01 20:11:24 James Westby bug added bug
2010-08-02 07:59:29 Julian Edwards summary getPackagesetsForUploader uses Store.find, which doesn't return an SQLObjectResultSet ResultSet doesn't implement __nonzero__
2010-08-02 07:59:51 Julian Edwards bug task added storm
2010-08-02 08:00:00 Julian Edwards soyuz: status New Invalid
2010-08-02 08:04:33 Julian Edwards description Hi, getPackagesetsForUploader uses Store.find, which doesn't return an SQLObject result set. This breaks assumptions, such as __nonzero__ being implemented, which caused a (small) bug in checkUpload(). Either it should be made to use a different method, or something should be done so that Launchpad's Stores return SQLObjectResult sets, as this is surprising and subtle, and could cause bigger problems. Thanks, James SQLObjectResultSet implements __nonzero__ but the native Storm ResultSet does not. This makes it harder to migrate old code.
2010-08-02 17:52:18 Jamu Kakar storm: assignee Jamu Kakar (jkakar)
2010-08-02 17:52:21 Jamu Kakar storm: milestone 0.17
2010-08-02 17:52:25 Jamu Kakar storm: importance Undecided Low
2010-08-02 17:52:28 Jamu Kakar storm: status New In Progress
2010-08-02 17:53:50 Jamu Kakar branch linked lp:~jkakar/storm/sqlobject-is-empty
2010-08-05 19:45:46 Jamu Kakar storm: status In Progress Fix Committed
2010-08-13 02:52:43 Jamu Kakar storm: status Fix Committed Fix Released